k0kubun/hamlit

View on GitHub

Showing 71 of 84 total issues

Method handle_ruby_multiline has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def handle_ruby_multiline(line)
      line.text.rstrip!
      return line unless is_ruby_multiline?(line.text)
      begin
        # Use already fetched @next_line in the first loop. Otherwise, fetch next
Severity: Minor
Found in lib/hamlit/parser/haml_parser.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

      unless (flat? && !closes_flat?(line) && !closes_flat?(@line)) ||
          (line_defined && @line.text[0] == ?: && line.full =~ %r[^#{@line.full[/^\s+/]}\s])
        return next_line if line.text.empty?

        handle_multiline(line)
Severity: Major
Found in lib/hamlit/parser/haml_parser.rb - About 40 mins to fix

    Method build_attributes has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def build_attributes(is_html, attr_wrapper, escape_attrs, hyphenate_data_attrs, attributes = {})
    Severity: Minor
    Found in lib/hamlit/parser/haml_attribute_builder.rb - About 35 mins to fix

      Method flatten_data_attributes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def flatten_data_attributes(data, key, join_char, seen = [])
              return {key => data} unless data.is_a?(Hash)
      
              return {key => nil} if seen.include? data.object_id
              seen << data.object_id
      Severity: Minor
      Found in lib/hamlit/parser/haml_attribute_builder.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method comment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def comment(text)
            if text[0..1] == '!['
              revealed = true
              text = text[1..-1]
            else
      Severity: Minor
      Found in lib/hamlit/parser/haml_parser.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_encoding has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_encoding(str)
            if str.valid_encoding?
              # Get rid of the Unicode BOM if possible
              # Shortcut for UTF-8 which might be the majority case
              if str.encoding == Encoding::UTF_8
      Severity: Minor
      Found in lib/hamlit/parser/haml_util.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_class_and_id has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.parse_class_and_id(list)
            attributes = {}
            return attributes if list.empty?
      
            list.scan(/([#.])([-:_a-zA-Z0-9\@]+)/) do |type, property|
      Severity: Minor
      Found in lib/hamlit/parser/haml_parser.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method build_data_attribute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def build_data_attribute(key, escape_attrs, quote, *hashes)
              attrs = []
              if hashes.size > 1 && hashes.all? { |h| h.is_a?(Hash) }
                data_value = merge_all_attrs(hashes)
              else
      Severity: Minor
      Found in lib/hamlit/attribute_builder.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method compile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def compile(node, &block)
              temple = [:multi]
              return temple if node.children.empty?
      
              temple << :whitespace if prepend_whitespace?(node)
      Severity: Minor
      Found in lib/hamlit/compiler/children_compiler.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method plain has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def plain(line, escape_html = nil)
            if block_opened?
              raise HamlSyntaxError.new(HamlError.message(:illegal_nesting_plain), @next_line.index)
            end
      
      
      Severity: Minor
      Found in lib/hamlit/parser/haml_parser.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method try_parse_haml_emacs_magic_comment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def try_parse_haml_emacs_magic_comment(scanner)
            pos = scanner.pos
            return unless scanner.scan(/.*?-\*-\s*/n)
            # From Ruby's parse.y
            return unless scanner.scan(/([^\s'":;]+)\s*:\s*("(?:\\.|[^"])*"|[^"\s;]+?)[\s;]*-\*-/n)
      Severity: Minor
      Found in lib/hamlit/parser/haml_util.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_key! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse_key!(tokens)
            _, type, str = tokens.shift
            case type
            when :on_sp
              parse_key!(tokens)
      Severity: Minor
      Found in lib/hamlit/attribute_parser.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return push plain(line.strip!(1), false) if line.text[1] == ?\s || line.text[1..2] == '#{'
      Severity: Major
      Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return push flat_script(line.strip!(2), false) if line.text[1] == FLAT_SCRIPT
        Severity: Major
        Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return push plain(line.strip!(1), :escape_html) if line.text[1] == ?\s || line.text[1..2] == '#{'
          Severity: Major
          Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return name, [:dynamic,
                    %!"#{content.each_with_object(''.dup) {|(t, v), s| s << (t == :str ? inspect_obj(v)[1...-1] : "\#{#{v}}")}}"!]
            Severity: Major
            Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return push doctype(line.text) if line.text[0, 3] == '!!!'
              Severity: Major
              Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return name, [:dynamic, var]
                Severity: Major
                Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return name, [:static, content.first[1]] if content.size == 1
                  Severity: Major
                  Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return push plain(line.strip!(2)) if line.text[1] == SCRIPT
                    Severity: Major
                    Found in lib/hamlit/parser/haml_parser.rb - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language