karma-runner/karma

View on GitHub
lib/config.js

Summary

Maintainability
F
4 days
Test Coverage

Function parseConfig has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

function parseConfig (configFilePath, cliOptions, parseOptions) {
  const promiseConfig = parseOptions && parseOptions.promiseConfig === true
  const throwErrors = parseOptions && parseOptions.throwErrors === true
  const shouldSetupLoggerEarly = promiseConfig
  if (shouldSetupLoggerEarly) {
Severity: Minor
Found in lib/config.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File config.js has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

const path = require('path')
const assert = require('assert')

Severity: Minor
Found in lib/config.js - About 5 hrs to fix

    Function normalizeConfig has 125 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function normalizeConfig (config, configFilePath) {
      function basePathResolve (relativePath) {
        if (helper.isUrlAbsolute(relativePath)) {
          return relativePath
        } else if (helper.isDefined(config.basePath) && helper.isDefined(relativePath)) {
    Severity: Major
    Found in lib/config.js - About 5 hrs to fix

      Function normalizeConfig has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
      Open

      function normalizeConfig (config, configFilePath) {
        function basePathResolve (relativePath) {
          if (helper.isUrlAbsolute(relativePath)) {
            return relativePath
          } else if (helper.isDefined(config.basePath) && helper.isDefined(relativePath)) {
      Severity: Minor
      Found in lib/config.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseConfig has 115 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function parseConfig (configFilePath, cliOptions, parseOptions) {
        const promiseConfig = parseOptions && parseOptions.promiseConfig === true
        const throwErrors = parseOptions && parseOptions.throwErrors === true
        const shouldSetupLoggerEarly = promiseConfig
        if (shouldSetupLoggerEarly) {
      Severity: Major
      Found in lib/config.js - About 4 hrs to fix

        Function constructor has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor () {
            this.LOG_DISABLE = constant.LOG_DISABLE
            this.LOG_ERROR = constant.LOG_ERROR
            this.LOG_WARN = constant.LOG_WARN
            this.LOG_INFO = constant.LOG_INFO
        Severity: Major
        Found in lib/config.js - About 2 hrs to fix

          Function createPatternObject has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function createPatternObject (pattern) {
            if (pattern && helper.isString(pattern)) {
              return helper.isUrlAbsolute(pattern)
                ? new UrlPattern(pattern)
                : new Pattern(pattern)
          Severity: Minor
          Found in lib/config.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return configModuleReturn.then(
                function onKarmaConfigModuleFulfilled (/* ignoredResolutionValue */) {
                  return finalizeConfig(config)
                },
                function onKarmaConfigModuleRejected (reason) {
          Severity: Major
          Found in lib/config.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return Promise.resolve(finalizeConfig(config))
            Severity: Major
            Found in lib/config.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return Promise.reject(exception)
              Severity: Major
              Found in lib/config.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return finalizeConfig(config)
                Severity: Major
                Found in lib/config.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (proxy.protocol.match(/https?:/) === null) {
                        log.warn(`"${proxy.protocol}" is not a supported upstream proxy protocol, defaulting to "http:"`)
                        proxy.protocol = 'http:'
                      }
                  Severity: Major
                  Found in lib/config.js and 1 other location - About 1 hr to fix
                  lib/config.js on lines 161..164

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (config.protocol.match(/https?:/) === null) {
                      log.warn(`"${config.protocol}" is not a supported protocol, defaulting to "http:"`)
                      config.protocol = 'http:'
                    }
                  Severity: Major
                  Found in lib/config.js and 1 other location - About 1 hr to fix
                  lib/config.js on lines 153..156

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function normalizeProxyPath (proxyPath) {
                    const normalizedProxyPath = normalizeUrl(proxyPath)
                  
                    if (normalizedProxyPath !== proxyPath) {
                      log.warn(`proxyPath normalized to "${normalizedProxyPath}"`)
                  Severity: Minor
                  Found in lib/config.js and 1 other location - About 55 mins to fix
                  lib/config.js on lines 85..93

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function normalizeUrlRoot (urlRoot) {
                    const normalizedUrlRoot = normalizeUrl(urlRoot)
                  
                    if (normalizedUrlRoot !== urlRoot) {
                      log.warn(`urlRoot normalized to "${normalizedUrlRoot}"`)
                  Severity: Minor
                  Found in lib/config.js and 1 other location - About 55 mins to fix
                  lib/config.js on lines 95..103

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Parsing error: Unexpected token {
                  Open

                  } catch {}
                  Severity: Minor
                  Found in lib/config.js by eslint

                  For more information visit Source: http://eslint.org/docs/rules/

                  There are no issues that match your filters.

                  Category
                  Status