Showing 11 of 18 total issues
Function connect
has 72 lines of code (exceeds 25 allowed). Consider refactoring. Open
passport.connect = function (req, query, profile, next) {
var user = {}
, provider;
// Get the authentication provider from the query.
Function register
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
exports.register = function (req, res, next) {
var email = req.param('email')
, username = req.param('username')
, password = req.param('password');
Function login
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
exports.login = function (req, identifier, password, next) {
var isEmail = validator.isEmail(identifier)
, query = {};
if (isEmail) {
Function loadStrategies
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
passport.loadStrategies = function () {
var self = this
, strategies = sails.config.passport;
Object.keys(strategies).forEach(function (key) {
Function callback
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
callback: function (req, res) {
function tryAgain (err) {
// Only certain error messages are returned via req.flash('error', someError)
// because we shouldn't expose internal authorization errors to the user.
Function callback
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
passport.callback = function (req, res, next) {
var provider = req.param('provider', 'local')
, action = req.param('action');
// Passport.js wasn't really built for local user registration, but it's nice
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if (err.invalidAttributes.email) {
req.flash('error', 'Error.Passport.Email.Exists');
}
else {
req.flash('error', 'Error.Passport.User.Exists');
Function exports
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
module.exports = function (req, accessToken, refreshToken, profile, next) {
Function exports
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
module.exports = function (req, token, tokenSecret, profile, next) {
Function callback
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
callback: function (req, res) {
function tryAgain (err) {
// Only certain error messages are returned via req.flash('error', someError)
// because we shouldn't expose internal authorization errors to the user.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function connect
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
passport.connect = function (req, query, profile, next) {
var user = {}
, provider;
// Get the authentication provider from the query.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"