Sign upLogin

katrotz/splitify

View on GitHub
Star
packages/meteor-jasmine/src/client/unit/assets/jasmine-jquery.js

Summary

Maintainability
F
1 mo
Test Coverage

File jasmine-jquery.js has 652 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
Jasmine-jQuery: a set of jQuery helpers for Jasmine tests.

Version 2.1.0
Severity: Major
Found in packages/meteor-jasmine/src/client/unit/assets/jasmine-jquery.js - About 1 day to fix

    Function loadFixtureIntoCache_ has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      jasmine.Fixtures.prototype.loadFixtureIntoCache_ = function (relativeUrl) {
    var self = this
      , url = this.makeFixtureUrl_(relativeUrl)
      , htmlText = ''
      , request = $.ajax({
    Severity: Minor
    Found in packages/meteor-jasmine/src/client/unit/assets/jasmine-jquery.js - About 1 hr to fix

      Function spyOn has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          spyOn: function (selector, eventName) {
      var handler = function (e) {
        var calls = (typeof data.spiedEvents[jasmine.spiedEventsKey(selector, eventName)] !== 'undefined') ? data.spiedEvents[jasmine.spiedEventsKey(selector, eventName)].calls : 0
        data.spiedEvents[jasmine.spiedEventsKey(selector, eventName)] = {
          args: jasmine.util.argsToArray(arguments),
      Severity: Minor
      Found in packages/meteor-jasmine/src/client/unit/assets/jasmine-jquery.js - About 1 hr to fix

        Function wasTriggeredWith has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            wasTriggeredWith: function (selector, eventName, expectedArgs, util, customEqualityTesters) {
        Severity: Minor
        Found in packages/meteor-jasmine/src/client/unit/assets/jasmine-jquery.js - About 35 mins to fix

          Avoid too many return statements within this function.
          Open

                      return { pass: false }
          Severity: Major
          Found in packages/meteor-jasmine/src/client/unit/assets/jasmine-jquery.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            +function (window, jasmine, $) { "use strict";

  jasmine.spiedEventsKey = function (selector, eventName) {
    return [$(selector).selector, eventName].toString()
  }
            Severity: Major
            Found in packages/meteor-jasmine/src/client/unit/assets/jasmine-jquery.js and 1 other location - About 1 mo to fix
            packages/meteor-jasmine/src/client/integration/assets/jasmine-jquery.js on lines 32..834

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 7233.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status