Sign upLogin

keeperofthenecklace/movieDB

View on GitHub
Star

Showing 7 of 9 total issues

Method dataframes_stats has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

        def dataframes_stats(method, filters = {})
          raise ArgumentError, 'Please provide 2 or more IMDd ids.' if $movie_data.length <= 1

          $data_key = {}
          $index = []
Severity: Minor
Found in lib/movieDB/data_analysis/statistics.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dataframes_stats has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def dataframes_stats(method, filters = {})
          raise ArgumentError, 'Please provide 2 or more IMDd ids.' if $movie_data.length <= 1

          $data_key = {}
          $index = []
Severity: Minor
Found in lib/movieDB/data_analysis/statistics.rb - About 1 hr to fix

    Method write_data has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.write_data(**options)
      if options[:imdb_tmdb].is_a? Hash

        options.each_pair do |k, v|
            if v.is_a? Hash
    Severity: Minor
    Found in lib/movieDB/data_store.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

              return @redis_db.flushall
    Severity: Major
    Found in lib/movieDB/data_store.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return @redis_db.ttl("#{id}")
      Severity: Major
      Found in lib/movieDB/data_store.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return @redis_db.hgetall("#{id}")
        Severity: Major
        Found in lib/movieDB/data_store.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return @redis_db.del("#{id}")
          Severity: Major
          Found in lib/movieDB/data_store.rb - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language