Sign upLogin

kellyirc/Warriors

View on GitHub
Star

Showing 6 of 10 total issues

Function ScenarioMap has a Cognitive Complexity of 159 (exceeds 5 allowed). Consider refactoring.
Open

var ScenarioMap = function(options) {

  var self = this;

  var chance = null;
Severity: Minor
Found in src/js/generators/scenariomap.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ScenarioMap has 193 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var ScenarioMap = function(options) {

  var self = this;

  var chance = null;
Severity: Major
Found in src/js/generators/scenariomap.js - About 7 hrs to fix

    Function create has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      create: function () {

    var tilemap = this.game.add.tilemap('world');
    tilemap.addTilesetImage('DungeonA2', 'DungeonA2', 16, 16);
    tilemap.addTilesetImage('WorldA2', 'WorldA2', 16, 16, 0, 0, 768);
    Severity: Minor
    Found in src/js/states/game.js - About 1 hr to fix

      Function fillInEmptyCaverns has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var fillInEmptyCaverns = function() {
    var copy = _.cloneDeep(self.world);
    var caverns = {};

    var countsForCavern = function(tile) {
      Severity: Minor
      Found in src/js/generators/scenariomap.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                    for(var keepstarty = y-self.keepRadius; keepstarty < y+self.keepRadius; keepstarty++) {

              self.world[keepstartx][keepstarty] = terrain.keep;

            }
        Severity: Major
        Found in src/js/generators/scenariomap.js - About 45 mins to fix

          Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            create: function () {

    var tilemap = this.game.add.tilemap('world');
    tilemap.addTilesetImage('DungeonA2', 'DungeonA2', 16, 16);
    tilemap.addTilesetImage('WorldA2', 'WorldA2', 16, 16, 0, 0, 768);
          Severity: Minor
          Found in src/js/states/game.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language