Sign upLogin

kellyirc/Warriors

View on GitHub
Star
src/js/generators/scenariomap.js

Summary

Maintainability
F
4 days
Test Coverage

Function ScenarioMap has a Cognitive Complexity of 159 (exceeds 5 allowed). Consider refactoring.
Open

var ScenarioMap = function(options) {

  var self = this;

  var chance = null;
Severity: Minor
Found in src/js/generators/scenariomap.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ScenarioMap has 193 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var ScenarioMap = function(options) {

  var self = this;

  var chance = null;
Severity: Major
Found in src/js/generators/scenariomap.js - About 7 hrs to fix

    Function fillInEmptyCaverns has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var fillInEmptyCaverns = function() {
    var copy = _.cloneDeep(self.world);
    var caverns = {};

    var countsForCavern = function(tile) {
    Severity: Minor
    Found in src/js/generators/scenariomap.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  for(var keepstarty = y-self.keepRadius; keepstarty < y+self.keepRadius; keepstarty++) {

              self.world[keepstartx][keepstarty] = terrain.keep;

            }
      Severity: Major
      Found in src/js/generators/scenariomap.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if(y < self.worldHeight - 1) {
        var top = copy[x][y+1];
        if(countsForCavern(top)) { iterateCaverns(ct, x, y+1); }
      }
        Severity: Minor
        Found in src/js/generators/scenariomap.js and 1 other location - About 35 mins to fix
        src/js/generators/scenariomap.js on lines 150..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if(x > 0) {
        var left = copy[x-1][y];
        if(countsForCavern(left)) { iterateCaverns(ct, x-1, y); }
      }
        Severity: Minor
        Found in src/js/generators/scenariomap.js and 1 other location - About 35 mins to fix
        src/js/generators/scenariomap.js on lines 145..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if(x < self.worldWidth-1) {
        var right = copy[x+1][y];
        if(countsForCavern(right)) { iterateCaverns(ct, x+1, y); }
      }
        Severity: Minor
        Found in src/js/generators/scenariomap.js and 1 other location - About 35 mins to fix
        src/js/generators/scenariomap.js on lines 140..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if(y > 0) {
        var bottom = copy[x][y-1];
        if(countsForCavern(bottom)) { iterateCaverns(ct, x, y-1); }
      }
        Severity: Minor
        Found in src/js/generators/scenariomap.js and 1 other location - About 35 mins to fix
        src/js/generators/scenariomap.js on lines 155..158

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status