kigster/arduino-library

View on GitHub

Showing 8 of 8 total issues

Method model_by_class has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        def model_by_class(source, **opts)
          case source
            when Hash
              from_hash(source)
            when String
Severity: Minor
Found in lib/arduino/library/model.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method entry_matches? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def entry_matches?(entry, opts)
        matches = true
        opts.each_pair do |attr, check|
          value   = entry.send(attr)
          matches &= case check
Severity: Minor
Found in lib/arduino/library/database.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method model_by_class has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def model_by_class(source, **opts)
          case source
            when Hash
              from_hash(source)
            when String
Severity: Minor
Found in lib/arduino/library/model.rb - About 1 hr to fix

    Method get_library_version has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def get_library_version(query, version: :latest)
              results = if query.key?(:name)
                          Model.find(**query).sort
                        else
                          Model.find(**query)
    Severity: Minor
    Found in lib/arduino/library/finder.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_library has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def find_library(model, version: :latest)
              raise ArgumentError, 'Model argument is required' unless model
              model = Model.from(model) unless model.is_a?(Model)
              return model unless model&.partial?
    
    
    Severity: Minor
    Found in lib/arduino/library/finder.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method search has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def search(**opts)
            limit = opts[:limit]
            opts.delete(:limit)
            match_list = []
    
    
    Severity: Minor
    Found in lib/arduino/library/database.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method version_to_i has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def version_to_i
            if version
              first, second, third = version.split(/\./).map(&:to_i)
              10 ** 6 * (first || 0) + 10 ** 3 * (second || 0) + (third || 0)
            else
    Severity: Minor
    Found in lib/arduino/library/model.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method attribute_presenter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def attribute_presenter(attr)
              value = model.send(attr) if model && model.respond_to?(attr)
              return unless value
              if value.is_a?(Array)
                self.presented << "#{attr}=#{model.send(attr).join(',')}\n"
    Severity: Minor
    Found in lib/arduino/library/presenters/properties.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language