Showing 146 of 200 total issues
Method credit_by_external_key
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
def credit_by_external_key(account_external_key, payment_method_id = nil, user = nil, reason = nil, comment = nil, options = {}, refresh_options = nil)
Method find_by_id
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def find_by_id(payment_method_id, included_deleted = false, with_plugin_info = false, plugin_property = [], audit = 'NONE', options = {})
Method transfer
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def transfer(requested_date = nil, billing_policy = nil, user = nil, reason = nil, comment = nil, options = {})
Method trigger_node_command
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def trigger_node_command(node_command, local_node_only, user = nil, reason = nil, comment = nil, options = {})
Method create
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def create(user = nil, reason = nil, comment = nil, requested_date = nil, call_completion = false, options = {})
Method find_in_batches_by_search_key
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def find_in_batches_by_search_key(search_key, offset = 0, limit = 100, with_balance = false, with_balance_and_cba = false, options = {})
Method find_by_transaction_external_key
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def find_by_transaction_external_key(external_key, with_plugin_info = false, with_attempts = false, plugin_property = [], audit = 'NONE', options = {})
Method find_by_external_key
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def find_by_external_key(external_key, included_deleted = false, with_plugin_info = false, plugin_property = [], audit = 'NONE', options = {})
Method trigger_invoice_dry_run
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def trigger_invoice_dry_run(account_id, target_date, upcoming_invoice_target_date, plugin_property = [], user = nil, reason = nil, comment = nil, options = {})
dry_run = InvoiceDryRunAttributes.new
dry_run.dry_run_type = upcoming_invoice_target_date ? 'UPCOMING_INVOICE' : 'TARGET_DATE'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_bulk_subscriptions
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def create_bulk_subscriptions(bulk_subscription_list, user = nil, reason = nil, comment = nil, entitlement_date = nil, billing_date = nil, call_completion_sec = nil, options = {})
params = {}
params[:callCompletion] = true unless call_completion_sec.nil?
params[:callTimeoutSec] = call_completion_sec unless call_completion_sec.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method from_json
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def from_json(resource_class, json)
# e.g. DELETE
return nil if json.nil? or json.size == 0
data = JSON.parse json
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find_by_transaction_id
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def find_by_transaction_id(transaction_id, with_plugin_info = false, with_attempts = false, plugin_property = [], audit = 'NONE', options = {})
Method add_payment_state_machine
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def add_payment_state_machine(plugin_name, state_machine_config, user = nil, reason = nil, comment = nil, options = {})
Method update_transaction_state
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_transaction_state(status, control_plugin_name = nil, user, reason, comment, options)
Method upload_tenant_user_key_value
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def upload_tenant_user_key_value(key_name, key_value, user = nil, reason = nil, comment = nil, options = {})
Method cancel
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def cancel(user = nil, reason = nil, comment = nil, requested_date = nil, entitlementPolicy = nil, billing_policy = nil, use_requested_date_for_billing = nil, options = {})
params = {}
params[:requestedDate] = requested_date unless requested_date.nil?
params[:billingPolicy] = billing_policy unless billing_policy.nil?
params[:entitlementPolicy] = entitlementPolicy unless entitlementPolicy.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_quantity
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_quantity(user = nil, reason = nil, comment = nil, effective_from_date = nil, force_new_quantity_with_past_effective_date = nil, options = {})
Method upload_tenant_plugin_config
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def upload_tenant_plugin_config(plugin_name, plugin_config, user = nil, reason = nil, comment = nil, options = {})
Method combo_payment
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def combo_payment(user, reason, comment, options, refresh_options = nil)
follow_location = true
follow_location = options.delete(:follow_location) if options.has_key?(:follow_location)
begin
created_transaction = self.class.post "#{Payment::KILLBILL_API_PAYMENTS_PREFIX}/combo",
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_default
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def set_default(payment_method_id, account_id, user = nil, reason = nil, comment = nil, options = {})