Sign upLogin

kirushik/critical_chain

View on GitHub
Star

Showing 2 of 215 total issues

Method update has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update
    @estimation = Estimation.find(params[:estimation_id]).decorate
    @estimation_item = EstimationItem.find(params[:id])

    authorize @estimation, :update?
Severity: Minor
Found in app/controllers/estimation_items_controller.rb - About 1 hr to fix

    Function activate_editables has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    var activate_editables = function () {
  $('.editable').editable({success: function(response, newValue) {
    if(!response.success) return response.msg; //msg will be shown in editable form
    var vals = response.additionalValues;
    if(vals) {
    Severity: Minor
    Found in app/assets/javascripts/application.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language