Sign upLogin

kiwitcms/Kiwi

View on GitHub
Star
tcms/testplans/static/testplans/js/search.js

Summary

Maintainability
D
1 day
Test Coverage

Function pageTestplansSearchReadyHandler has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function pageTestplansSearchReadyHandler () {
    initializeDateTimePicker('#id_before')
    initializeDateTimePicker('#id_after')

    const rowsNotShownMessage = $('#main-element').data('trans-some-rows-not-shown')
Severity: Major
Found in tcms/testplans/static/testplans/js/search.js - About 4 hrs to fix

    Function pageTestplansSearchReadyHandler has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    export function pageTestplansSearchReadyHandler () {
    initializeDateTimePicker('#id_before')
    initializeDateTimePicker('#id_after')

    const rowsNotShownMessage = $('#main-element').data('trans-some-rows-not-shown')
    Severity: Minor
    Found in tcms/testplans/static/testplans/js/search.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ajax has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            ajax: function (data, callbackF, settings) {
            const params = {}

            if ($('#id_name').val()) {
                params.name__icontains = $('#id_name').val()
    Severity: Minor
    Found in tcms/testplans/static/testplans/js/search.js - About 1 hr to fix

      Function createdCell has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Invalid

                      createdCell: function (td, cellData, rowData, rowIndex, colIndex) {
      Severity: Minor
      Found in tcms/testplans/static/testplans/js/search.js - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                tags.forEach(function (element) {
            if (tagsPerPlan[element.plan] === undefined) {
                tagsPerPlan[element.plan] = []
            }
        Severity: Major
        Found in tcms/testplans/static/testplans/js/search.js and 2 other locations - About 3 hrs to fix
        tcms/testcases/static/testcases/js/search.js on lines 18..27
        tcms/testcases/static/testcases/js/search.js on lines 32..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 14 locations. Consider refactoring.
        Invalid

                    if ($('#id_after').val()) {
                params.create_date__gte = $('#id_after').data('DateTimePicker').date().format('YYYY-MM-DD 00:00:00')
            }
        Severity: Major
        Found in tcms/testplans/static/testplans/js/search.js and 13 other locations - About 1 hr to fix
        tcms/bugs/static/bugs/js/search.js on lines 43..45
        tcms/bugs/static/bugs/js/search.js on lines 47..49
        tcms/testcases/static/testcases/js/search.js on lines 76..78
        tcms/testcases/static/testcases/js/search.js on lines 80..82
        tcms/testplans/static/testplans/js/search.js on lines 61..63
        tcms/testruns/static/testruns/js/search.js on lines 69..71
        tcms/testruns/static/testruns/js/search.js on lines 73..75
        tcms/testruns/static/testruns/js/search.js on lines 77..79
        tcms/testruns/static/testruns/js/search.js on lines 81..83
        tcms/testruns/static/testruns/js/search.js on lines 85..87
        tcms/testruns/static/testruns/js/search.js on lines 89..91
        tcms/testruns/static/testruns/js/search.js on lines 93..95
        tcms/testruns/static/testruns/js/search.js on lines 97..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 14 locations. Consider refactoring.
        Invalid

                    if ($('#id_before').val()) {
                params.create_date__lte = $('#id_before').data('DateTimePicker').date().format('YYYY-MM-DD 23:59:59')
            }
        Severity: Major
        Found in tcms/testplans/static/testplans/js/search.js and 13 other locations - About 1 hr to fix
        tcms/bugs/static/bugs/js/search.js on lines 43..45
        tcms/bugs/static/bugs/js/search.js on lines 47..49
        tcms/testcases/static/testcases/js/search.js on lines 76..78
        tcms/testcases/static/testcases/js/search.js on lines 80..82
        tcms/testplans/static/testplans/js/search.js on lines 65..67
        tcms/testruns/static/testruns/js/search.js on lines 69..71
        tcms/testruns/static/testruns/js/search.js on lines 73..75
        tcms/testruns/static/testruns/js/search.js on lines 77..79
        tcms/testruns/static/testruns/js/search.js on lines 81..83
        tcms/testruns/static/testruns/js/search.js on lines 85..87
        tcms/testruns/static/testruns/js/search.js on lines 89..91
        tcms/testruns/static/testruns/js/search.js on lines 93..95
        tcms/testruns/static/testruns/js/search.js on lines 97..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    if (element.id in tagsPerPlan) {
                element.tag = tagsPerPlan[element.id]
            } else {
                element.tag = []
            }
        Severity: Major
        Found in tcms/testplans/static/testplans/js/search.js and 3 other locations - About 45 mins to fix
        tcms/testcases/static/testcases/js/search.js on lines 45..49
        tcms/testcases/static/testcases/js/search.js on lines 51..55
        tcms/testruns/static/testruns/js/search.js on lines 37..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status