Sign upLogin

kleros/kleros-v2

View on GitHub
Star

feat(subgraph): add StakeSet entity and handler tweak
#1901

kemuru wants to merge feat/add-stake-set-event-and-type into dev
Compare on GitHub
Failed
2 issues to fix.

Showing 4 of 4 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
New

export function handleStakeSet(event: StakeSetEvent): void {
  const jurorAddress = event.params._address.toHexString();
  const courtID = event.params._courtID.toString();
 
  updateJurorStake(jurorAddress, courtID.toString(), SortitionModule.bind(event.address), event.block.timestamp);
Severity: Major
Found in subgraph/core-university/src/SortitionModule.ts and 1 other location - About 1 day to fix
subgraph/core/src/SortitionModule.ts on lines 27..45

Identical blocks of code found in 2 locations. Consider refactoring.
New

export function handleStakeSet(event: StakeSetEvent): void {
  const jurorAddress = event.params._address.toHexString();
  const courtID = event.params._courtID.toString();
 
  updateJurorStake(jurorAddress, courtID.toString(), SortitionModule.bind(event.address), event.block.timestamp);
Severity: Major
Found in subgraph/core/src/SortitionModule.ts and 1 other location - About 1 day to fix
subgraph/core-university/src/SortitionModule.ts on lines 8..26

Identical blocks of code found in 2 locations. Consider refactoring.
Fixed

Severity: Major
Found in subgraph/core-university/src/SortitionModule.ts and 1 other location - About 4 hrs to fix
subgraph/core/src/SortitionModule.ts on lines 26..34

Identical blocks of code found in 2 locations. Consider refactoring.
Fixed

Severity: Major
Found in subgraph/core/src/SortitionModule.ts and 1 other location - About 4 hrs to fix
subgraph/core-university/src/SortitionModule.ts on lines 7..15

There are no issues that match your filters.

Category
Status
FileMaintainability
subgraph/core-university/src/SortitionModule.ts
B
D
+1 day
subgraph/core/src/SortitionModule.ts
C
D
+1 day