knsv/mermaid

View on GitHub
packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js

Summary

Maintainability
D
1 day
Test Coverage

Function svgDrawLineForCommits has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function svgDrawLineForCommits(svg, fromId, toId, direction, color) {
  logger.debug('svgDrawLineForCommits: ', fromId, toId);
  const fromBbox = getElementCoords(svg.select('#node-' + fromId + ' circle'));
  const toBbox = getElementCoords(svg.select('#node-' + toId + ' circle'));
  switch (direction) {
Severity: Major
Found in packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js - About 3 hrs to fix

    File gitGraphRenderer-old.js has 309 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { curveBasis, line, select } from 'd3';
    
    import db from './gitGraphAst.js';
    import { logger } from '../../logger.js';
    import { interpolateToCurve } from '../../utils.js';
    Severity: Minor
    Found in packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js - About 3 hrs to fix

      Function renderCommitHistory has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function renderCommitHistory(svg, commitId, branches, direction) {
        let commit;
        const numCommits = Object.keys(allCommitsDict).length;
        if (typeof commitId === 'string') {
          do {
      Severity: Major
      Found in packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js - About 3 hrs to fix

        Function draw has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const draw = function (txt, id, ver) {
          try {
            logger.debug('in gitgraph renderer', txt + '\n', 'id:', id, ver);
        
            config = Object.assign(config, apiConfig, db.getOptions());
        Severity: Minor
        Found in packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js - About 1 hr to fix

          Function svgDrawLineForCommits has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function svgDrawLineForCommits(svg, fromId, toId, direction, color) {
          Severity: Minor
          Found in packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    const lineEnd = { x: toBbox.left + toBbox.width, y: toBbox.top + toBbox.height / 2 };
            Severity: Minor
            Found in packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js and 1 other location - About 35 mins to fix
            packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js on lines 116..119

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    const lineStart = {
                      x: fromBbox.left - config.nodeSpacing,
                      y: toBbox.top + toBbox.height / 2,
                    };
            Severity: Minor
            Found in packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js and 1 other location - About 35 mins to fix
            packages/mermaid/src/diagrams/git/gitGraphRenderer-old.js on lines 120..120

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status