Sign upLogin

knsv/mermaid

View on GitHub
Star
packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js

Summary

Maintainability
C
1 day
Test Coverage

File stateDiagram-v2.spec.js has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { parser } from './parser/stateDiagram.jison';
import stateDb from './stateDb.js';
import stateDiagram from './parser/stateDiagram.jison';

describe('state diagram V2, ', function () {
Severity: Minor
Found in packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js - About 4 hrs to fix

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        it('simple with accDescription', function () {
      const str = `stateDiagram-v2\n
      accDescr: a simple description of the diagram
      State1 : this is another string
      [*] --> State1
    Severity: Major
    Found in packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js and 6 other locations - About 1 hr to fix
    packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js on lines 23..33
    packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js on lines 46..57
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 19..29
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 30..41
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 42..56
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 57..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        it('simple with title', function () {
      const str = `stateDiagram-v2\n
      accTitle: a simple title of the diagram
      State1 : this is another string
      [*] --> State1
    Severity: Major
    Found in packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js and 6 other locations - About 1 hr to fix
    packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js on lines 23..33
    packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js on lines 34..45
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 19..29
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 30..41
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 42..56
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 57..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        it('simple', function () {
      const str = `stateDiagram-v2\n
      State1 : this is another string
      [*] --> State1
      State1 --> [*]
    Severity: Major
    Found in packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js and 6 other locations - About 1 hr to fix
    packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js on lines 34..45
    packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js on lines 46..57
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 19..29
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 30..41
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 42..56
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 57..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it('should handle note statements', function () {
      const str = `stateDiagram-v2\n
      [*] --> Active
      Active --> Inactive
    Severity: Minor
    Found in packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js and 1 other location - About 35 mins to fix
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 321..336

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it('should handle concurrent state', function () {
      const str = `stateDiagram-v2\n
      [*] --> Active

      state Active {
    Severity: Minor
    Found in packages/mermaid/src/diagrams/state/stateDiagram-v2.spec.js and 1 other location - About 35 mins to fix
    packages/mermaid/src/diagrams/state/stateDiagram.spec.js on lines 296..310

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status