knsv/mermaid

View on GitHub
packages/mermaid/src/diagrams/state/stateRenderer-v2.js

Summary

Maintainability
D
1 day
Test Coverage

Function setupNode has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const setupNode = (g, parent, parsedItem, diagramStates, diagramDb, altFlag) => {
  const itemId = parsedItem.id;
  const classStr = getClassesFromDbInfo(diagramStates[itemId]);

  if (itemId !== 'root') {
Severity: Major
Found in packages/mermaid/src/diagrams/state/stateRenderer-v2.js - About 5 hrs to fix

    File stateRenderer-v2.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as graphlib from 'dagre-d3-es/src/graphlib/index.js';
    import { select } from 'd3';
    import { getConfig } from '../../diagram-api/diagramAPI.js';
    import { render } from '../../dagre-wrapper/index.js';
    import { log } from '../../logger.js';
    Severity: Minor
    Found in packages/mermaid/src/diagrams/state/stateRenderer-v2.js - About 3 hrs to fix

      Function draw has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const draw = async function (text, id, _version, diag) {
        log.info('Drawing state diagram (v2)', id);
        nodeDb = {};
        // Fetch the default direction, use TD if none was found
        let dir = diag.db.getDirection();
      Severity: Major
      Found in packages/mermaid/src/diagrams/state/stateRenderer-v2.js - About 2 hrs to fix

        Function setupDoc has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const setupDoc = (g, parentParsedItem, doc, diagramStates, diagramDb, altFlag) => {
          // graphItemCount = 0;
          log.trace('items', doc);
          doc.forEach((item) => {
            switch (item.stmt) {
        Severity: Minor
        Found in packages/mermaid/src/diagrams/state/stateRenderer-v2.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                    if (newNode.description === itemId) {
                      // If the previous description was this, remove it
                      newNode.description = [parsedItem.description];
                    } else {
                      newNode.description = [newNode.description, parsedItem.description];
          Severity: Major
          Found in packages/mermaid/src/diagrams/state/stateRenderer-v2.js - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              const vBox = `${svgBounds.x - padding} ${svgBounds.y - padding} ${width} ${height}`;
            Severity: Minor
            Found in packages/mermaid/src/diagrams/state/stateRenderer-v2.js and 1 other location - About 35 mins to fix
            packages/mermaid/src/diagrams/class/classRenderer.js on lines 270..270

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status