Sign upLogin

koic/active_pstore

View on GitHub
Star

Showing 5 of 5 total issues

Method save has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def save
      ActivePStore::Base.use_connection do |connection|
        if new_record?
          @id = SecureRandom.hex
Severity: Minor
Found in lib/active_pstore/persistence.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def find(*ids)
      ids = ids.map {|id| id.is_a?(ActivePStore::Base) ? id.id : id }

      _find(*ids).tap do |ret|
        if ids.size == 1
Severity: Minor
Found in lib/active_pstore/finder_methods.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method database_configuration has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def database_configuration
        yaml = Pathname.new('config/active_pstore.yml')

        config = if yaml && yaml.exist?
          require 'yaml'
Severity: Minor
Found in lib/active_pstore/application/configuration.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(attributes = nil)
      if attributes.present?
        attributes.each do |attr, val|
          if respond_to? "#{attr}=".to_sym
            self.public_send("#{attr}=", val)
Severity: Minor
Found in lib/active_pstore/base.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decide has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def decide(conditions, method)
        raise 'Illegal method error.' unless %i(reject select).include? method

        return @scope if conditions.empty?
Severity: Minor
Found in lib/active_pstore/query_methods.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language