Showing 11 of 26 total issues
Function init
has 73 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func init() {
/*
* version
*/
if version == "" {
Method CLI.ItemsPull
has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring. Open
Open
func (c *CLI) ItemsPull(params *ItemsPullParameters) error {
all := *params.FlagAll.Get(c.command, true)
if all && len(params.Args) > 0 {
return ErrIDsWithAll
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function Configure
has 8 return statements (exceeds 4 allowed). Open
Open
func Configure(params *ConfigureParameters) error {
cfg, err := config.Load()
if err != nil {
cfg = &config.Config{}
}
Method CLI.ItemsPull
has 8 return statements (exceeds 4 allowed). Open
Open
func (c *CLI) ItemsPull(params *ItemsPullParameters) error {
all := *params.FlagAll.Get(c.command, true)
if all && len(params.Args) > 0 {
return ErrIDsWithAll
}
Function WriteMarkdown
has 7 return statements (exceeds 4 allowed). Open
Open
func WriteMarkdown(w io.Writer, md string, frontMatter interface{}) error {
y, err := yaml.Marshal(frontMatter)
if err != nil {
return err
}
Function loadCache
has 6 return statements (exceeds 4 allowed). Open
Open
func loadCache() (*cache, error) {
p, err := cachePath()
if err != nil {
return nil, err
}
Method CLI.ItemsNew
has 5 return statements (exceeds 4 allowed). Open
Open
func (c *CLI) ItemsNew(params *ItemsNewParameters) error {
filename := params.Args[0]
if !strings.HasSuffix(filename, ".md") {
filename += ".md"
}
Function NotifyNewRelease
has 5 return statements (exceeds 4 allowed). Open
Open
func NotifyNewRelease(w io.Writer, version string) error {
c, err := loadCache()
if err != nil {
return err
}
Function saveCache
has 5 return statements (exceeds 4 allowed). Open
Open
func saveCache(c *cache) error {
p, err := cachePath()
if err != nil {
return err
}
Method CLI.ItemsPush
has 5 return statements (exceeds 4 allowed). Open
Open
func (c *CLI) ItemsPush(params *ItemsPushParameters) error {
for _, filename := range params.Args {
md, fm, err := c.readMarkdown(filename)
if err != nil {
return err
Method Client.doRequest
has 5 return statements (exceeds 4 allowed). Open
Open
func (cl *Client) doRequest(req *http.Request, dst interface{}) error {
resp, err := cl.httpClient.Do(req)
if err != nil {
return err
}