kongou-ae/redpen-validator

View on GitHub
use-numeral-properly.js

Summary

Maintainability
C
1 day
Test Coverage

Function validateSentence has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

function validateSentence(sentence) {
    // 参考
    // https://www.jtf.jp/jp/style_guide/pdf/jtf_style_guide.pdf
    // 2.2.2. 算用数字と漢数字の使い分け
    // 数量を表現し、数を数えられるものは算用数字を使用します。任意の数に置き換えても通用する語句がこれに該当します。序数詞(「第~回」「~番目」「~回目」)も算用数字を使います。
Severity: Minor
Found in use-numeral-properly.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateSentence has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function validateSentence(sentence) {
    // 参考
    // https://www.jtf.jp/jp/style_guide/pdf/jtf_style_guide.pdf
    // 2.2.2. 算用数字と漢数字の使い分け
    // 数量を表現し、数を数えられるものは算用数字を使用します。任意の数に置き換えても通用する語句がこれに該当します。序数詞(「第~回」「~番目」「~回目」)も算用数字を使います。
Severity: Major
Found in use-numeral-properly.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

                ) return null;
    Severity: Major
    Found in use-numeral-properly.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              if ( sentence.tokens[k].tags[6].match(/十進法|二進法|十六進法/) ) return addError('数を数えられるものは算用数字を利用します' , sentence );
      Severity: Major
      Found in use-numeral-properly.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    ) return null;
        Severity: Major
        Found in use-numeral-properly.js - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status