krafthaus/bauhaus

View on GitHub
bower_components/jquery/src/data.js

Summary

Maintainability
F
1 wk
Test Coverage

Function internalRemoveData has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function internalRemoveData( elem, name, pvt ) {
    if ( !jQuery.acceptData( elem ) ) {
        return;
    }

Severity: Minor
Found in bower_components/jquery/src/data.js - About 1 hr to fix

    Function internalData has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function internalData( elem, name, data, pvt /* Internal Use Only */ ) {
        if ( !jQuery.acceptData( elem ) ) {
            return;
        }
    
    
    Severity: Minor
    Found in bower_components/jquery/src/data.js - About 1 hr to fix

      Function data has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          data: function( key, value ) {
              var i, name, data,
                  elem = this[0],
                  attrs = elem && elem.attributes;
      
      
      Severity: Minor
      Found in bower_components/jquery/src/data.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                if ( attrs[ i ] ) {
                                    name = attrs[ i ].name;
                                    if ( name.indexOf( "data-" ) === 0 ) {
                                        name = jQuery.camelCase( name.slice(5) );
                                        dataAttr( elem, name, data[ name ] );
        Severity: Major
        Found in bower_components/jquery/src/data.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if ( name in thisCache ) {
                                  name = [ name ];
                              } else {
                                  name = name.split(" ");
                              }
          Severity: Major
          Found in bower_components/jquery/src/data.js - About 45 mins to fix

            Consider simplifying this complex logical expression.
            Open

                if ( (!id || !cache[id] || (!pvt && !cache[id].data)) && data === undefined && typeof name === "string" ) {
                    return;
                }
            Severity: Major
            Found in bower_components/jquery/src/data.js - About 40 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function internalData( elem, name, data, pvt /* Internal Use Only */ ) {
                  if ( !jQuery.acceptData( elem ) ) {
                      return;
                  }
              
              
              Severity: Major
              Found in bower_components/jquery/src/data.js and 1 other location - About 3 days to fix
              bower_components/jquery/dist/jquery.js on lines 3681..3768

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 549.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function internalRemoveData( elem, name, pvt ) {
                  if ( !jQuery.acceptData( elem ) ) {
                      return;
                  }
              
              
              Severity: Major
              Found in bower_components/jquery/src/data.js and 1 other location - About 2 days to fix
              bower_components/jquery/dist/jquery.js on lines 3770..3858

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 484.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              jQuery.fn.extend({
                  data: function( key, value ) {
                      var i, name, data,
                          elem = this[0],
                          attrs = elem && elem.attributes;
              Severity: Major
              Found in bower_components/jquery/src/data.js and 1 other location - About 2 days to fix
              bower_components/jquery/dist/jquery.js on lines 3895..3954

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 409.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function dataAttr( elem, key, data ) {
                  // If nothing was found internally, try to fetch any
                  // data from the HTML5 data-* attribute
                  if ( data === undefined && elem.nodeType === 1 ) {
              
              
              Severity: Major
              Found in bower_components/jquery/src/data.js and 1 other location - About 1 day to fix
              bower_components/jquery/dist/jquery.js on lines 3633..3662

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 218.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              jQuery.extend({
                  cache: {},
              
                  // The following elements (space-suffixed to avoid Object.prototype collisions)
                  // throw uncatchable exceptions if you attempt to set expando properties
              Severity: Major
              Found in bower_components/jquery/src/data.js and 1 other location - About 1 day to fix
              bower_components/jquery/dist/jquery.js on lines 3860..3893

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 201.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function isEmptyDataObject( obj ) {
                  var name;
                  for ( name in obj ) {
              
                      // if the public data object is empty, the private is still empty
              Severity: Major
              Found in bower_components/jquery/src/data.js and 1 other location - About 1 hr to fix
              bower_components/jquery/dist/jquery.js on lines 3665..3679

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status