Sign upLogin

krafthaus/bauhaus

View on GitHub
Star
bower_components/tinymce/plugins/image/plugin.js

Summary

Maintainability
F
3 days
Test Coverage

Function showDialog has 273 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function showDialog(imageList) {
        var win, data = {}, dom = editor.dom, imgElm = editor.selection.getNode();
        var width, height, imageListCtrl, classListCtrl, imageDimensions = editor.settings.image_dimensions !== false;

        function recalcSize() {
Severity: Major
Found in bower_components/tinymce/plugins/image/plugin.js - About 1 day to fix

    File plugin.js has 347 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * plugin.js
 *
 * Copyright, Moxiecode Systems AB
 * Released under LGPL License.
    Severity: Minor
    Found in bower_components/tinymce/plugins/image/plugin.js - About 4 hrs to fix

      Function onSubmitForm has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function onSubmitForm() {
            function waitLoad(imgElm) {
                function selectImage() {
                    imgElm.onload = imgElm.onerror = null;
      Severity: Major
      Found in bower_components/tinymce/plugins/image/plugin.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function createImageList(callback) {
        return function() {
            var imageList = editor.settings.image_list;

            if (typeof(imageList) == "string") {
        Severity: Major
        Found in bower_components/tinymce/plugins/image/plugin.js and 1 other location - About 5 hrs to fix
        bower_components/tinymce/plugins/link/plugin.js on lines 14..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (!altCtrl.value() || (e.lastControl && altCtrl.value() == e.lastControl.text())) {
                        altCtrl.value(e.control.text());
                    }
        Severity: Major
        Found in bower_components/tinymce/plugins/image/plugin.js and 1 other location - About 1 hr to fix
        bower_components/tinymce/plugins/link/plugin.js on lines 66..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        values: buildListItems(
                    imageList,
                    function(item) {
                        item.value = editor.convertURL(item.value || item.url, 'src');
                    },
        Severity: Major
        Found in bower_components/tinymce/plugins/image/plugin.js and 1 other location - About 1 hr to fix
        bower_components/tinymce/plugins/link/plugin.js on lines 189..195

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status