krafthaus/bauhaus

View on GitHub
bower_components/tinymce/plugins/lists/plugin.js

Summary

Maintainability
F
4 days
Test Coverage

File plugin.js has 571 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * plugin.js
 *
 * Copyright, Moxiecode Systems AB
 * Released under LGPL License.
Severity: Major
Found in bower_components/tinymce/plugins/lists/plugin.js - About 1 day to fix

    Function applyList has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function applyList(listName) {
                var rng = selection.getRng(true), bookmark = createBookmark(rng), listItemName = 'LI';
    
                listName = listName.toUpperCase();
    
    
    Severity: Major
    Found in bower_components/tinymce/plugins/lists/plugin.js - About 3 hrs to fix

      Function outdent has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function outdent(li) {
                  var ul = li.parentNode, ulParent = ul.parentNode, newBlock;
      
                  function removeEmptyLi(li) {
                      if (dom.isEmpty(li)) {
      Severity: Major
      Found in bower_components/tinymce/plugins/lists/plugin.js - About 2 hrs to fix

        Function getSelectedTextBlocks has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    function getSelectedTextBlocks() {
                        var textBlocks = [], root = editor.getBody();
        
                        function getEndPointNode(start) {
                            var container, offset;
        Severity: Major
        Found in bower_components/tinymce/plugins/lists/plugin.js - About 2 hrs to fix

          Function backspaceDelete has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  self.backspaceDelete = function(isForward) {
                      function findNextCaretContainer(rng, isForward) {
                          var node = rng.startContainer, offset = rng.startOffset;
          
                          if (node.nodeType == 3 && (isForward ? offset < node.data.length : offset > 0)) {
          Severity: Major
          Found in bower_components/tinymce/plugins/lists/plugin.js - About 2 hrs to fix

            Function createNewTextBlock has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function createNewTextBlock(contentNode, blockName) {
                        var node, textBlock, fragment = dom.createFragment(), hasContentNode;
                        var blockElements = editor.schema.getBlockElements();
            
                        if (editor.settings.forced_root_block) {
            Severity: Minor
            Found in bower_components/tinymce/plugins/lists/plugin.js - About 1 hr to fix

              Function indent has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      function indent(li) {
                          var sibling, newList;
              
                          function mergeLists(from, to) {
                              var node;
              Severity: Minor
              Found in bower_components/tinymce/plugins/lists/plugin.js - About 1 hr to fix

                Function moveToBookmark has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        function moveToBookmark(bookmark) {
                            function restoreEndPoint(start) {
                                var container, offset, node;
                
                                function nodeIndex(container) {
                Severity: Minor
                Found in bower_components/tinymce/plugins/lists/plugin.js - About 1 hr to fix

                  Function createBookmark has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          function createBookmark(rng) {
                              var bookmark = {};
                  
                              function setupEndPoint(start) {
                                  var offsetNode, container, offset;
                  Severity: Minor
                  Found in bower_components/tinymce/plugins/lists/plugin.js - About 1 hr to fix

                    Function outdentSelection has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            function outdentSelection() {
                                var listElements = getSelectedListItems();
                    
                                if (listElements.length) {
                                    var bookmark = createBookmark(selection.getRng(true));
                    Severity: Minor
                    Found in bower_components/tinymce/plugins/lists/plugin.js - About 1 hr to fix

                      Function restoreEndPoint has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                                  function restoreEndPoint(start) {
                                      var container, offset, node;
                      
                                      function nodeIndex(container) {
                                          var node = container.parentNode.firstChild, idx = 0;
                      Severity: Minor
                      Found in bower_components/tinymce/plugins/lists/plugin.js - About 1 hr to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if (!isForward && removeList(li.parentNode.nodeName)) {
                                                    return true;
                                                }
                        Severity: Major
                        Found in bower_components/tinymce/plugins/lists/plugin.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                      if (!textBlock) {
                                                          textBlock = dom.create(blockName);
                                                          fragment.appendChild(textBlock);
                                                      }
                          Severity: Major
                          Found in bower_components/tinymce/plugins/lists/plugin.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                        if (listElements[y] === node) {
                                                            listElements.splice(i, 1);
                                                            break;
                                                        }
                            Severity: Major
                            Found in bower_components/tinymce/plugins/lists/plugin.js - About 45 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                              return true;
                              Severity: Major
                              Found in bower_components/tinymce/plugins/lists/plugin.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                return true;
                                Severity: Major
                                Found in bower_components/tinymce/plugins/lists/plugin.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                              return false;
                                  Severity: Major
                                  Found in bower_components/tinymce/plugins/lists/plugin.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                                return false;
                                    Severity: Major
                                    Found in bower_components/tinymce/plugins/lists/plugin.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                                      return false;
                                      Severity: Major
                                      Found in bower_components/tinymce/plugins/lists/plugin.js - About 30 mins to fix

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                        if (ulParent.nodeName == "LI") {
                                                            dom.insertAfter(li, ulParent);
                                                            li.appendChild(ul);
                                                            removeEmptyLi(ulParent);
                                                        } else if (isListNode(ulParent)) {
                                        Severity: Major
                                        Found in bower_components/tinymce/plugins/lists/plugin.js and 1 other location - About 1 hr to fix
                                        bower_components/tinymce/plugins/lists/plugin.js on lines 329..336

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 55.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                        if (ulParent.nodeName == "LI") {
                                                            dom.insertAfter(li, ulParent);
                                                        } else if (isListNode(ulParent)) {
                                                            dom.insertAfter(li, ul);
                                                        } else {
                                        Severity: Major
                                        Found in bower_components/tinymce/plugins/lists/plugin.js and 1 other location - About 1 hr to fix
                                        bower_components/tinymce/plugins/lists/plugin.js on lines 316..325

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 55.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        There are no issues that match your filters.

                                        Category
                                        Status