Sign upLogin

krambox/buderus2mqtt

View on GitHub
Star

Showing 4 of 10 total issues

Function getKM200 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getKM200(url, done) {
  var options = {
    url: 'http://' + km200host + url,
    headers: {
      'Content-type': 'application/json',
Severity: Minor
Found in km200mqtt.js - About 1 hr to fix

Function requestKM200 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function requestKM200(host) {
  getKM200(host, '/notifications', function(result, json) {
    if (json !== undefined) {
      //console.log(JSON.stringify(json.values))
      var data = json.values
Severity: Minor
Found in notifications.js - About 1 hr to fix

Avoid too many return statements within this function.
Open

        if (a.t > b.t) return -1
Severity: Major
Found in notifications.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return 0
Severity: Major
Found in notifications.js - About 30 mins to fix
Severity
Category
Status
Source
Language