Sign upLogin

krateng/maloja

View on GitHub
Star
maloja/web/static/js/manualscrobble.js

Summary

Maintainability
D
2 days
Test Coverage

Function scrobbleNew has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function scrobbleNew() {
    var artistnodes = document.getElementById("artists_td").getElementsByTagName("span");
    var artists = [];
    for (let node of artistnodes) {
        artists.push(node.textContent);
Severity: Minor
Found in maloja/web/static/js/manualscrobble.js - About 1 hr to fix

    Function scrobble has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function scrobble(artists,title,albumartists,album,timestamp) {
    Severity: Minor
    Found in maloja/web/static/js/manualscrobble.js - About 35 mins to fix

      Function scrobbleNew has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function scrobbleNew() {
    var artistnodes = document.getElementById("artists_td").getElementsByTagName("span");
    var artists = [];
    for (let node of artistnodes) {
        artists.push(node.textContent);
      Severity: Minor
      Found in maloja/web/static/js/manualscrobble.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function removeAlbumartist() {
    var artists = document.getElementById("albumartists_td").getElementsByTagName("span")
    var lastartist = artists[artists.length-1]
    document.getElementById("albumartists_td").removeChild(lastartist);
    if (artists.length < 1) {
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 3 hrs to fix
      maloja/web/static/js/manualscrobble.js on lines 49..56

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function removeArtist() {
    var artists = document.getElementById("artists_td").getElementsByTagName("span")
    var lastartist = artists[artists.length-1]
    document.getElementById("artists_td").removeChild(lastartist);
    if (artists.length < 1) {
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 3 hrs to fix
      maloja/web/static/js/manualscrobble.js on lines 57..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function addArtist(artist) {
    var newartistfield = document.getElementById("artists");
    var artistelement = document.createElement("span");
    artistelement.innerHTML = artist;
    artistelement.style = "padding:5px;";
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 2 hrs to fix
      maloja/web/static/js/manualscrobble.js on lines 15..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function addAlbumartist(artist) {
    var newartistfield = document.getElementById("albumartists");
    var artistelement = document.createElement("span");
    artistelement.innerHTML = artist;
    artistelement.style = "padding:5px;";
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 2 hrs to fix
      maloja/web/static/js/manualscrobble.js on lines 7..14

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function keyDetect(event) {
    if (event.key === "Enter" || event.key === "Tab") { addEnteredArtist() }
    if (event.key === "Backspace" && document.getElementById("artists").value == "") { removeArtist() }
}
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 2 hrs to fix
      maloja/web/static/js/manualscrobble.js on lines 28..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function keyDetect2(event) {
    if (event.key === "Enter" || event.key === "Tab") { addEnteredAlbumartist() }
    if (event.key === "Backspace" && document.getElementById("albumartists").value == "") { removeAlbumartist() }
}
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 2 hrs to fix
      maloja/web/static/js/manualscrobble.js on lines 24..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function addEnteredArtist() {
    var newartistfield = document.getElementById("artists");
    var newartist = newartistfield.value.trim();
    newartistfield.value = "";
    if (newartist != "") {
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 1 hr to fix
      maloja/web/static/js/manualscrobble.js on lines 41..48

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function addEnteredAlbumartist() {
    var newartistfield = document.getElementById("albumartists");
    var newartist = newartistfield.value.trim();
    newartistfield.value = "";
    if (newartist != "") {
      Severity: Major
      Found in maloja/web/static/js/manualscrobble.js and 1 other location - About 1 hr to fix
      maloja/web/static/js/manualscrobble.js on lines 33..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status