kuasha/cosmos

View on GitHub
samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js

Summary

Maintainability
F
3 mos
Test Coverage

File sortable.js has 933 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery UI Sortable 1.11.0
 * http://jqueryui.com
 *
 * Copyright 2014 jQuery Foundation and other contributors
Severity: Major
Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 2 days to fix

    Function _clear has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _clear: function(event, noPropagation) {
    
            this.reverting = false;
            // We delay all events that have to be triggered to after the point where the placeholder has been removed and
            // everything else normalized again
    Severity: Major
    Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 3 hrs to fix

      Function _mouseStart has 75 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _mouseStart: function(event, overrideHandle, noActivation) {
      
              var i, body,
                  o = this.options;
      
      
      Severity: Major
      Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 3 hrs to fix

        Function _mouseDrag has 75 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _mouseDrag: function(event) {
                var i, item, itemElement, intersection,
                    o = this.options,
                    scrolled = false;
        
        
        Severity: Major
        Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 3 hrs to fix

          Function _contactContainers has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _contactContainers: function(event) {
                  var i, j, dist, itemWithLeastDistance, posProperty, sizeProperty, cur, nearBottom, floating, axis,
                      innermostContainer = null,
                      innermostIndex = null;
          
          
          Severity: Major
          Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 2 hrs to fix

            Function _generatePosition has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _generatePosition: function(event) {
            
                    var top, left,
                        o = this.options,
                        pageX = event.pageX,
            Severity: Minor
            Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                      if (this.floating && horizontalDirection) {
                          return ((horizontalDirection === "right" && isOverRightHalf) || (horizontalDirection === "left" && !isOverRightHalf));
                      } else {
                          return verticalDirection && ((verticalDirection === "down" && isOverBottomHalf) || (verticalDirection === "up" && !isOverBottomHalf));
                      }
              Severity: Critical
              Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                Consider simplifying this complex logical expression.
                Open

                        if(!(/^(document|window|parent)$/).test(o.containment)) {
                            ce = $(o.containment)[0];
                            co = $(o.containment).offset();
                            over = ($(ce).css("overflow") !== "hidden");
                
                
                Severity: Critical
                Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                  Function _createPlaceholder has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      _createPlaceholder: function(that) {
                          that = that || this;
                          var className,
                              o = that.options;
                  
                  
                  Severity: Minor
                  Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                    Function _mouseCapture has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        _mouseCapture: function(event, overrideHandle) {
                            var currentItem = null,
                                validHandle = false,
                                that = this;
                    
                    
                    Severity: Minor
                    Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                      Function cancel has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          cancel: function() {
                      
                              if(this.dragging) {
                      
                                  this._mouseUp({ target: null });
                      Severity: Minor
                      Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                        Function _refreshItems has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            _refreshItems: function(event) {
                        
                                this.items = [];
                                this.containers = [this];
                        
                        
                        Severity: Minor
                        Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                          Function refreshPositions has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              refreshPositions: function(fast) {
                          
                                  //This has to be redone because due to the item being moved out/into the offsetParent, the offsetParent's position will change
                                  if(this.offsetParent && this.helper) {
                                      this.offset.parent = this._getParentOffset();
                          Severity: Minor
                          Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                            Consider simplifying this complex logical expression.
                            Open

                                    if ( this.options.tolerance === "pointer" ||
                                        this.options.forcePointerForContainers ||
                                        (this.options.tolerance !== "pointer" && this.helperProportions[this.floating ? "width" : "height"] > item[this.floating ? "width" : "height"])
                                    ) {
                                        return isOverElement;
                            Severity: Major
                            Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 1 hr to fix

                              Avoid too many return statements within this function.
                              Open

                                      return true;
                              Severity: Major
                              Found in samples/adminpanel/app/bower_components/jquery-ui/ui/sortable.js - About 30 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                return $.widget("ui.sortable", $.ui.mouse, {
                                    version: "1.11.0",
                                    widgetEventPrefix: "sort",
                                    ready: false,
                                    options: {
                                samples/adminpanel/app/bower_components/jquery-ui/jquery-ui.js on lines 4219..5499

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 14741.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 8 locations. Consider refactoring.
                                Open

                                (function( factory ) {
                                    if ( typeof define === "function" && define.amd ) {
                                
                                        // AMD. Register as an anonymous module.
                                        define([
                                samples/adminpanel/app/bower_components/jquery-ui/ui/draggable.js on lines 11..1016
                                samples/adminpanel/app/bower_components/jquery-ui/ui/menu.js on lines 11..640
                                samples/adminpanel/app/bower_components/jquery-ui/ui/resizable.js on lines 11..1028
                                samples/adminpanel/app/bower_components/jquery-ui/ui/selectable.js on lines 11..287
                                samples/adminpanel/app/bower_components/jquery-ui/ui/slider.js on lines 11..688
                                samples/adminpanel/app/bower_components/jquery-ui/ui/spinner.js on lines 11..514
                                samples/adminpanel/app/bower_components/jquery-ui/ui/tooltip.js on lines 11..444

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 57.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status