kubenetworks/kubevpn

View on GitHub

Showing 333 of 526 total issues

Method ConnectOptions.addRouteDynamic has 78 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *ConnectOptions) addRouteDynamic(ctx context.Context) error {
    tunName, e := c.GetTunDeviceName()
    if e != nil {
        return e
    }
Severity: Major
Found in pkg/handler/connect.go - About 2 hrs to fix

    Method Options.Connect has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func (option *Options) Connect(ctx context.Context, sshConfig *pkgssh.SshConfig, transferImage bool, portBindings nat.PortMap) error {
        switch option.ConnectMode {
        case ConnectModeHost:
            daemonCli := daemon.GetClient(false)
            if daemonCli == nil {
    Severity: Minor
    Found in pkg/dev/options.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ConnectOptions.portForward has 77 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (c *ConnectOptions) portForward(ctx context.Context, portPair []string) error {
        firstCtx, firstCancelFunc := context.WithCancel(ctx)
        defer firstCancelFunc()
        var errChan = make(chan error, 1)
        go func() {
    Severity: Major
    Found in pkg/handler/connect.go - About 2 hrs to fix

      Method Options.CreateConnectContainer has 77 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (option *Options) CreateConnectContainer(portBindings nat.PortMap) (*RunConfig, error) {
          portMap, portSet, err := option.GetExposePort(portBindings)
          if err != nil {
              return nil, err
          }
      Severity: Major
      Found in pkg/dev/options.go - About 2 hrs to fix

        Function createTun has 76 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func createTun(cfg Config) (conn net.Conn, itf *net.Interface, err error) {
            if cfg.Addr == "" && cfg.Addr6 == "" {
                err = fmt.Errorf("IPv4 address and IPv6 address can not be empty at same time")
                return
            }
        Severity: Major
        Found in pkg/tun/tun_linux.go - About 2 hrs to fix

          Function NewKubeVPNCommand has 73 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func NewKubeVPNCommand() *cobra.Command {
              var cmd = &cobra.Command{
                  Use:   "kubevpn",
                  Short: i18n.T("KubeVPN offers a Cloud-Native Dev Environment that seamlessly connects to your Kubernetes cluster network."),
                  Long: templates.LongDesc(`
          Severity: Minor
          Found in cmd/kubevpn/cmds/root.go - About 1 hr to fix

            Method ConnectOptions.startLocalTunServe has 73 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (c *ConnectOptions) startLocalTunServe(ctx context.Context, forwardAddress string, lite bool) (err error) {
                log.Debugf("IPv4: %s, IPv6: %s", c.localTunIPv4.IP.String(), c.localTunIPv6.IP.String())
            
                var cidrList []*net.IPNet
                if !lite {
            Severity: Minor
            Found in pkg/handler/connect.go - About 1 hr to fix

              Function run has 71 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func run(ctx context.Context, cli *client.Client, dockerCli *command.DockerCli, runConfig *RunConfig) (id string, err error) {
                  rand.New(rand.NewSource(time.Now().UnixNano()))
              
                  var config = runConfig.config
                  var hostConfig = runConfig.hostConfig
              Severity: Minor
              Found in pkg/dev/docker_utils.go - About 1 hr to fix

                Function createTun has 71 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func createTun(cfg Config) (conn net.Conn, itf *net.Interface, err error) {
                    if cfg.Addr == "" && cfg.Addr6 == "" {
                        err = fmt.Errorf("IPv4 address and IPv6 address can not be empty at same time")
                        return
                    }
                Severity: Minor
                Found in pkg/tun/tun_bsd.go - About 1 hr to fix

                  Function file_dhcpserver_proto_init has 71 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func file_dhcpserver_proto_init() {
                      if File_dhcpserver_proto != nil {
                          return
                      }
                      if !protoimpl.UnsafeEnabled {
                  Severity: Minor
                  Found in pkg/dhcp/rpc/dhcpserver.pb.go - About 1 hr to fix

                    Function main has 70 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func main() {
                        // git describe --tags `git rev-list --tags --max-count=1`
                        commitId, err2 := exec.Command("git", "rev-list", "--tags", "--max-count=1").Output()
                        if err2 != nil {
                            panic(err2)
                    Severity: Minor
                    Found in pkg/util/krew/main.go - About 1 hr to fix

                      Function ConvertK8sApiServerToDomain has 69 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func ConvertK8sApiServerToDomain(kubeConfigPath string) (newPath string, err error) {
                          var kubeConfigBytes []byte
                          kubeConfigBytes, err = os.ReadFile(kubeConfigPath)
                          if err != nil {
                              return
                      Severity: Minor
                      Found in pkg/util/kube.go - About 1 hr to fix

                        Function init has 69 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        func init() {
                            http.Handle("/ws", websocket.Handler(func(conn *websocket.Conn) {
                                var sshConfig pkgssh.SshConfig
                                b := conn.Request().Header.Get("ssh")
                                if err := json.Unmarshal([]byte(b), &sshConfig); err != nil {
                        Severity: Minor
                        Found in pkg/daemon/handler/ssh.go - About 1 hr to fix

                          Method CloneOptions.SyncDir has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
                          Open

                          func (d *CloneOptions) SyncDir(ctx context.Context, labels string) error {
                              list, err := util.GetRunningPodList(ctx, d.targetClientset, d.TargetNamespace, labels)
                              if err != nil {
                                  return err
                              }
                          Severity: Minor
                          Found in pkg/handler/clone.go - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method Manager.RentIP has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
                          Open

                          func (m *Manager) RentIP(ctx context.Context) (*net.IPNet, *net.IPNet, error) {
                              addrs, _ := net.InterfaceAddrs()
                              var isAlreadyExistedFunc = func(ip net.IP) bool {
                                  for _, addr := range addrs {
                                      if addr == nil {
                          Severity: Minor
                          Found in pkg/dhcp/dhcp.go - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function CmdDisconnect has 68 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func CmdDisconnect(f cmdutil.Factory) *cobra.Command {
                              var all = false
                              var clusterIDs []string
                              cmd := &cobra.Command{
                                  Use:   "disconnect",
                          Severity: Minor
                          Found in cmd/kubevpn/cmds/disconnect.go - About 1 hr to fix

                            Function InjectVPNSidecar has 68 lines of code (exceeds 50 allowed). Consider refactoring.
                            Open

                            func InjectVPNSidecar(ctx1 context.Context, factory util.Factory, namespace, workload string, c util2.PodRouteConfig) error {
                                object, err := util2.GetUnstructuredObject(factory, namespace, workload)
                                if err != nil {
                                    return err
                                }
                            Severity: Minor
                            Found in pkg/inject/proxy.go - About 1 hr to fix

                              Method Server.Get has 68 lines of code (exceeds 50 allowed). Consider refactoring.
                              Open

                              func (svr *Server) Get(ctx context.Context, req *rpc.GetRequest) (*rpc.GetResponse, error) {
                                  if svr.connect == nil || svr.connect.Context() == nil {
                                      return nil, errors.New("not connected")
                                  }
                                  if svr.resourceLists == nil {
                              Severity: Minor
                              Found in pkg/daemon/action/get.go - About 1 hr to fix

                                Function NewStack has 68 lines of code (exceeds 50 allowed). Consider refactoring.
                                Open

                                func NewStack(ctx context.Context, tun stack.LinkEndpoint) *stack.Stack {
                                    s := stack.New(stack.Options{
                                        NetworkProtocols: []stack.NetworkProtocolFactory{
                                            ipv4.NewProtocol,
                                            ipv6.NewProtocol,
                                Severity: Minor
                                Found in pkg/core/gvisorstack.go - About 1 hr to fix

                                  Method PortForwarder.handleConnection has 67 lines of code (exceeds 50 allowed). Consider refactoring.
                                  Open

                                  func (pf *PortForwarder) handleConnection(conn net.Conn, port ForwardedPort) {
                                      defer conn.Close()
                                  
                                      if pf.out != nil {
                                          fmt.Fprintf(pf.out, "Handling connection for %d\n", port.Local)
                                  Severity: Minor
                                  Found in pkg/util/portforward.go - About 1 hr to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language