kumabook/stickynotes

View on GitHub
src/content_scripts/StickyView.js

Summary

Maintainability
F
4 days
Test Coverage

File StickyView.js has 458 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import browser from 'webextension-polyfill';
import ColorPicker from './ColorPicker';
import TagEditor from './TagEditor';
import Dialog from './Dialog';
import StickyMenu from './StickyMenu';
Severity: Minor
Found in src/content_scripts/StickyView.js - About 7 hrs to fix

    Function drag has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    StickyView.prototype.drag = function drag(e) {
      const c      = StickyView.classes;
      const pos    = this.getElementPosition(this.dom);
      const right  = pos.left + parseInt(this.dom.style.width, 10);
      const bottom = pos.top + parseInt(this.dom.style.height, 10);
    Severity: Minor
    Found in src/content_scripts/StickyView.js - About 1 hr to fix

      Function showMenu has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      StickyView.prototype.showMenu = function showMenu() {
        const c = StickyView.classes;
        this.hideDialog();
        this.dialog = new Dialog({ className: c.MENU_DIALOG });
        this.dialog.push(new StickyMenu({
      Severity: Minor
      Found in src/content_scripts/StickyView.js - About 1 hr to fix

        Function createDom has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        StickyView.prototype.createDom = function createDom() {
          /* eslint-disable no-underscore-dangle */
          const c    = StickyView.classes;
          const id   = `sticky${this.sticky.id}`;
          const doc  = document;
        Severity: Minor
        Found in src/content_scripts/StickyView.js - About 1 hr to fix

          Function resize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          StickyView.prototype.resize = function resize(elem, e) {
            const c           = StickyView.classes;
            const that        = this;
            const startX      = e.clientX;
            const startY      = e.clientY;
          Severity: Minor
          Found in src/content_scripts/StickyView.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            StickyView.prototype.unbind = function unbind() {
              this.dom.removeEventListener('mousedown', this.drag);
              this.dom.removeEventListener('dblclick', this.maximize);
            
              this.deleteButton.removeEventListener('click', this.onClickDeleteButton);
            Severity: Major
            Found in src/content_scripts/StickyView.js and 1 other location - About 1 day to fix
            src/content_scripts/StickyView.js on lines 279..292

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 222.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            StickyView.prototype.bind = function bind() {
              this.deleteButton.addEventListener('click', this.onClickDeleteButton);
              this.minimizeButton.addEventListener('click', this.onClickMinimizeButton);
              this.editTagButton.addEventListener('click', this.onClickEditTagButton);
              this.editTagButton.addEventListener('focus', this.onClickEditTagButton);
            Severity: Major
            Found in src/content_scripts/StickyView.js and 1 other location - About 1 day to fix
            src/content_scripts/StickyView.js on lines 294..307

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 222.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            StickyView.prototype.toggleMenuDialog = function toggleMenuDialog() {
              const c = StickyView.classes;
              this.hideDialog();
              if (!this.dialog || this.dialog.className !== c.MENU_DIALOG) {
                this.showMenu();
            Severity: Major
            Found in src/content_scripts/StickyView.js and 1 other location - About 2 hrs to fix
            src/content_scripts/StickyView.js on lines 458..464

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 86.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            StickyView.prototype.toggleTagDialog = function toggleTagDialog() {
              const c = StickyView.classes;
              this.hideDialog();
              if (!this.dialog || this.dialog.className !== c.TAGS_DIALOG) {
                this.showTagDialog();
            Severity: Major
            Found in src/content_scripts/StickyView.js and 1 other location - About 2 hrs to fix
            src/content_scripts/StickyView.js on lines 450..456

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 86.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status