Function FouthAnnual
has 221 lines of code (exceeds 25 allowed). Consider refactoring. Invalid
YD.FouthAnnual = function () {
this.$unLoginBtn = $('.unLogin');
this.$tabBtnEles = $('#tabBtns');
this.$startDate = '2018-01-04 10:30:00';
this.$endDate = '2018-06-14 23:59:59';
Function events
has 188 lines of code (exceeds 25 allowed). Consider refactoring. Invalid
this.events = function () {
var self = this;
self.$unLoginBtn.on('click', function () {
YD.showLogin();
});
Function FouthAnnual
has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring. Invalid
YD.FouthAnnual = function () {
this.$unLoginBtn = $('.unLogin');
this.$tabBtnEles = $('#tabBtns');
this.$startDate = '2018-01-04 10:30:00';
this.$endDate = '2018-06-14 23:59:59';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function start_count_down_time
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Invalid
self.start_count_down_time = function () {
var arr,
nextDate,
curDate = new Date(),
nextTime = new Date(),
Function getDateDiff
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Invalid
self.getDateDiff = function (startTime, endTime) {
var timeArray = [],
timeEnd = endTime.getTime(),
timeNow = startTime, // 获取当前时间
timeDistance, // 时间差:活动结束时间减去当前时间
Similar blocks of code found in 2 locations. Consider refactoring. Invalid
success: function (res) {
var result = $.parseJSON(res);
if (result && result.code === 0) {
self.YDDialog(result.message, false, 1);
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 127.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Invalid
success: function (res) {
var result = $.parseJSON(res);
if (result && result.err_code === 0) {
self.YDDialog(result.err_msg, false, 1);
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 127.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Invalid
for (i = 2; i < 6; i++) {
if ($('#floor' + i).offset().top <= wst) {
$('.menu_item').removeClass('active');
$('a[href="#floor' + i + '"]').addClass('active');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 89.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76