lab2023/tcmb_currency

View on GitHub

Showing 2 of 2 total issues

Method fetch_rate! has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def fetch_rate!(from, to, date)
        from_to_s = Money::Currency.wrap(from).to_s
        to_to_s = Money::Currency.wrap(to).to_s
        from_rate = 1.0
        to_rate = 1.0
Severity: Minor
Found in lib/money/bank/tcmb_currency.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exchange_with! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def exchange_with!(*args)
        from = args[0]
        to_currency = args[1]
        date = args[2]
        return from if same_currency?(from.currency, to_currency)
Severity: Minor
Found in lib/money/bank/tcmb_currency.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language