Showing 12 of 16 total issues
Function getParameterType has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring. Open
public static function getParameterType(ReflectionType $type) : string {
if ( $type instanceof ReflectionNamedType ) {
if ( $type->getName() === 'string') return 'string';
else if ( $type->getName() === 'array') return 'array';
else if ( $type->getName() === 'int' ) return 'int';- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getParameterValueFromRequest has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring. Open
public static function getParameterValueFromRequest(Request $request, string $name, string $type) {
if ( $type === 'array') {
return $request->getArrayParameter($name);
} else if ( $type === 'int' ) {
return $request->getIntParameter($name);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method createSession has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function createSession(PDO $pdo, string $username, string $password) : array {
try {
$row = UtilPDO::selectRow($pdo, "SELECT user_id, name, password_hash FROM users WHERE name = :name", [
'name' => $username
]);Method create_session_guest has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function create_session_guest(string $nickname) : ResponseJson {
$dao = $this->getDataAccessUser();
$pdo = $dao->getPDO();
$user_id = uniqid();Function getPDO has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function getPDO() : PDO {
if ( !isset($this->pdo) ) {
$config = $this->getConfig();
$database_type = $config->getType();
if ( $database_type === self::TYPE_MYSQL ) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return 'string';Avoid too many return statements within this method. Open
return $request;Avoid too many return statements within this method. Open
return $request->getFileParameter($name);Avoid too many return statements within this method. Open
else if ( $type->getName() === InputFileList::class ) return InputFileList::class;Avoid too many return statements within this method. Open
else if ( $type->getName() === Request::class ) return Request::class;Avoid too many return statements within this method. Open
return $request->getFileListParameter($name);Function getError has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getError(string $error_id) : array {
$filename = $this->getLogFilename();
if ( file_exists($filename) ) {
foreach (Util::readFileByLine($filename) as $line ) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"