lacymorrow/crossover

View on GitHub
src/main/crossover.js

Summary

Maintainability
D
2 days
Test Coverage

File crossover.js has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const { globalShortcut, nativeTheme, shell, app } = require( 'electron' )
const { SHADOW_WINDOW_OFFSET, DEFAULT_THEME, SETTINGS_WINDOW_DEVTOOLS, APP_BACKGROUND_OPACITY } = require( '../config/config' )
const { checkboxTrue, hexToRgbA } = require( '../config/utils' )
const dock = require( './dock' )
const iohook = require( './iohook' )
Severity: Minor
Found in src/main/crossover.js - About 4 hrs to fix

    Function keyboardShortcuts has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const keyboardShortcuts = () => {
    
        /* Default accelerator */
        const accelerator = 'Control+Shift+Alt'
    
    
    Severity: Major
    Found in src/main/crossover.js - About 3 hrs to fix

      Function lockWindow has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

      const lockWindow = ( lock, targetWindow = windows.win ) => {
      
          log.info( `Locked: ${lock}` )
      
          /* Actions */
      Severity: Minor
      Found in src/main/crossover.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function syncSettings has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const syncSettings = ( options = preferences.preferences ) => {
      
          log.info( 'Sync options' )
      
          // Set app size
      Severity: Major
      Found in src/main/crossover.js - About 2 hrs to fix

        Function openSettingsWindow has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const openSettingsWindow = async () => {
        
            // Don't do anything if locked
            if ( preferences.value( 'hidden.locked' ) ) {
        
        
        Severity: Minor
        Found in src/main/crossover.js - About 1 hr to fix

          Function lockWindow has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const lockWindow = ( lock, targetWindow = windows.win ) => {
          
              log.info( `Locked: ${lock}` )
          
              /* Actions */
          Severity: Minor
          Found in src/main/crossover.js - About 1 hr to fix

            Function initShadowWindow has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const initShadowWindow = async () => {
            
                log.info( 'Trying to create shadow window...' )
            
                if ( preferences.value( 'hidden.locked' ) ) {
            Severity: Minor
            Found in src/main/crossover.js - About 1 hr to fix

              Function syncSettings has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              const syncSettings = ( options = preferences.preferences ) => {
              
                  log.info( 'Sync options' )
              
                  // Set app size
              Severity: Minor
              Found in src/main/crossover.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function openSettingsWindow has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              const openSettingsWindow = async () => {
              
                  // Don't do anything if locked
                  if ( preferences.value( 'hidden.locked' ) ) {
              
              
              Severity: Minor
              Found in src/main/crossover.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function registerKeyboardShortcuts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              const registerKeyboardShortcuts = () => {
              
                  // Register all shortcuts
                  const { keybinds } = Preferences.getDefaults()
                  const custom = preferences.value( 'keybinds' ) // Defaults
              Severity: Minor
              Found in src/main/crossover.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      {
                          action: 'moveRight',
                          keybind: `${accelerator}+Right`,
                          fn() {
              
              
              Severity: Minor
              Found in src/main/crossover.js and 2 other locations - About 35 mins to fix
              src/main/crossover.js on lines 129..137
              src/main/crossover.js on lines 138..146

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      {
                          action: 'moveDown',
                          keybind: `${accelerator}+Down`,
                          fn() {
              
              
              Severity: Minor
              Found in src/main/crossover.js and 2 other locations - About 35 mins to fix
              src/main/crossover.js on lines 138..146
              src/main/crossover.js on lines 147..155

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      {
                          action: 'moveLeft',
                          keybind: `${accelerator}+Left`,
                          fn() {
              
              
              Severity: Minor
              Found in src/main/crossover.js and 2 other locations - About 35 mins to fix
              src/main/crossover.js on lines 129..137
              src/main/crossover.js on lines 147..155

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status