lancetw/react-isomorphic-bundle

View on GitHub
src/client/admin/actions/PostActions.js

Summary

Maintainability
F
4 days
Test Coverage

Function fetchAll has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

async function fetchAll (offset, limit, start, end, keyword, status) {
Severity: Minor
Found in src/client/admin/actions/PostActions.js - About 45 mins to fix

    Expected property shorthand.
    Open

          .query({ keyword: keyword })

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Unexpected string concatenation.
    Open

          .set('Authorization', 'JWT ' + token)

    Suggest using template literals instead of string concatenation. (prefer-template)

    In ES2015 (ES6), we can use template literals instead of string concatenation.

    var str = "Hello, " + name + "!";
    /*eslint-env es6*/
    
    var str = `Hello, ${name}!`;

    Rule Details

    This rule is aimed to flag usage of + operators with strings.

    Examples

    Examples of incorrect code for this rule:

    /*eslint prefer-template: "error"*/
    
    var str = "Hello, " + name + "!";
    var str = "Time: " + (12 * 60 * 60 * 1000);

    Examples of correct code for this rule:

    /*eslint prefer-template: "error"*/
    /*eslint-env es6*/
    
    var str = "Hello World!";
    var str = `Hello, ${name}!`;
    var str = `Time: ${12 * 60 * 60 * 1000}`;
    
    // This is reported by `no-useless-concat`.
    var str = "Hello, " + "World!";

    When Not To Use It

    This rule should not be used in ES3/5 environments.

    In ES2015 (ES6) or later, if you don't want to be notified about string concatenation, you can safely disable this rule.

    Related Rules

    Expected property shorthand.
    Open

              offset: offset,

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

              status: status,

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

              keyword: keyword

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

          .query({ offset: offset })

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

              end: end,

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

          .query({ status: status })

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

          .query({ end: end })

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Unexpected function expression.
    Open

          .end(function (err, res) {

    Suggest using arrow functions as callbacks. (prefer-arrow-callback)

    Arrow functions are suited to callbacks, because:

    • this keywords in arrow functions bind to the upper scope's.
    • The notation of the arrow function is shorter than function expression's.

    Rule Details

    This rule is aimed to flag usage of function expressions in an argument list.

    The following patterns are considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    
    foo(function(a) { return a; });
    foo(function() { return this.a; }.bind(this));

    The following patterns are not considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    /*eslint-env es6*/
    
    foo(a => a);
    foo(function*() { yield; });
    
    // this is not a callback.
    var foo = function foo(a) { return a; };
    
    // using `this` without `.bind(this)`.
    foo(function() { return this.a; });
    
    // recursively.
    foo(function bar(n) { return n && n + bar(n - 1); });

    Options

    This rule takes one optional argument, an object which is an options object.

    allowNamedFunctions

    This is a boolean option and it is false by default. When set to true, the rule doesn't warn on named functions used as callbacks.

    Examples of correct code for the { "allowNamedFunctions": true } option:

    /*eslint prefer-arrow-callback: ["error", { "allowNamedFunctions": true }]*/
    
    foo(function bar() {});

    allowUnboundThis

    This is a boolean option and it is true by default. When set to false, this option allows the use of this without restriction and checks for dynamically assigned this values such as when using Array.prototype.map with a context argument. Normally, the rule will flag the use of this whenever a function does not use bind() to specify the value of this constantly.

    Examples of incorrect code for the { "allowUnboundThis": false } option:

    /*eslint prefer-arrow-callback: ["error", { "allowUnboundThis": false }]*/
    /*eslint-env es6*/
    
    foo(function() { this.a; });
    
    foo(function() { (() => this); });
    
    someArray.map(function (itm) { return this.doSomething(itm); }, someObject);

    When Not To Use It

    This rule should not be used in ES3/5 environments.

    In ES2015 (ES6) or later, if you don't want to be notified about function expressions in an argument list, you can safely disable this rule. Source: http://eslint.org/docs/rules/

    Unexpected function expression.
    Open

          .end(function (err, res) {

    Suggest using arrow functions as callbacks. (prefer-arrow-callback)

    Arrow functions are suited to callbacks, because:

    • this keywords in arrow functions bind to the upper scope's.
    • The notation of the arrow function is shorter than function expression's.

    Rule Details

    This rule is aimed to flag usage of function expressions in an argument list.

    The following patterns are considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    
    foo(function(a) { return a; });
    foo(function() { return this.a; }.bind(this));

    The following patterns are not considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    /*eslint-env es6*/
    
    foo(a => a);
    foo(function*() { yield; });
    
    // this is not a callback.
    var foo = function foo(a) { return a; };
    
    // using `this` without `.bind(this)`.
    foo(function() { return this.a; });
    
    // recursively.
    foo(function bar(n) { return n && n + bar(n - 1); });

    Options

    This rule takes one optional argument, an object which is an options object.

    allowNamedFunctions

    This is a boolean option and it is false by default. When set to true, the rule doesn't warn on named functions used as callbacks.

    Examples of correct code for the { "allowNamedFunctions": true } option:

    /*eslint prefer-arrow-callback: ["error", { "allowNamedFunctions": true }]*/
    
    foo(function bar() {});

    allowUnboundThis

    This is a boolean option and it is true by default. When set to false, this option allows the use of this without restriction and checks for dynamically assigned this values such as when using Array.prototype.map with a context argument. Normally, the rule will flag the use of this whenever a function does not use bind() to specify the value of this constantly.

    Examples of incorrect code for the { "allowUnboundThis": false } option:

    /*eslint prefer-arrow-callback: ["error", { "allowUnboundThis": false }]*/
    /*eslint-env es6*/
    
    foo(function() { this.a; });
    
    foo(function() { (() => this); });
    
    someArray.map(function (itm) { return this.doSomething(itm); }, someObject);

    When Not To Use It

    This rule should not be used in ES3/5 environments.

    In ES2015 (ES6) or later, if you don't want to be notified about function expressions in an argument list, you can safely disable this rule. Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

              limit: limit,

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Unexpected string concatenation.
    Open

          .get(LOCAL_PATH + '/api/admin/v1/posts')

    Suggest using template literals instead of string concatenation. (prefer-template)

    In ES2015 (ES6), we can use template literals instead of string concatenation.

    var str = "Hello, " + name + "!";
    /*eslint-env es6*/
    
    var str = `Hello, ${name}!`;

    Rule Details

    This rule is aimed to flag usage of + operators with strings.

    Examples

    Examples of incorrect code for this rule:

    /*eslint prefer-template: "error"*/
    
    var str = "Hello, " + name + "!";
    var str = "Time: " + (12 * 60 * 60 * 1000);

    Examples of correct code for this rule:

    /*eslint prefer-template: "error"*/
    /*eslint-env es6*/
    
    var str = "Hello World!";
    var str = `Hello, ${name}!`;
    var str = `Time: ${12 * 60 * 60 * 1000}`;
    
    // This is reported by `no-useless-concat`.
    var str = "Hello, " + "World!";

    When Not To Use It

    This rule should not be used in ES3/5 environments.

    In ES2015 (ES6) or later, if you don't want to be notified about string concatenation, you can safely disable this rule.

    Related Rules

    Unexpected string concatenation.
    Open

          .set('Authorization', 'JWT ' + token)

    Suggest using template literals instead of string concatenation. (prefer-template)

    In ES2015 (ES6), we can use template literals instead of string concatenation.

    var str = "Hello, " + name + "!";
    /*eslint-env es6*/
    
    var str = `Hello, ${name}!`;

    Rule Details

    This rule is aimed to flag usage of + operators with strings.

    Examples

    Examples of incorrect code for this rule:

    /*eslint prefer-template: "error"*/
    
    var str = "Hello, " + name + "!";
    var str = "Time: " + (12 * 60 * 60 * 1000);

    Examples of correct code for this rule:

    /*eslint prefer-template: "error"*/
    /*eslint-env es6*/
    
    var str = "Hello World!";
    var str = `Hello, ${name}!`;
    var str = `Time: ${12 * 60 * 60 * 1000}`;
    
    // This is reported by `no-useless-concat`.
    var str = "Hello, " + "World!";

    When Not To Use It

    This rule should not be used in ES3/5 environments.

    In ES2015 (ES6) or later, if you don't want to be notified about string concatenation, you can safely disable this rule.

    Related Rules

    Expected property shorthand.
    Open

          .query({ limit: limit })

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

          .query({ start: start })

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

              start: start,

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected parentheses around arrow function argument having a body with curly braces.
    Open

      return async dispatch => {

    Require parens in arrow function arguments (arrow-parens)

    Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions.

    Rule Details

    This rule enforces parentheses around arrow function parameters regardless of arity. For example:

    /*eslint-env es6*/
    
    // Bad
    a => {}
    
    // Good
    (a) => {}

    Following this style will help you find arrow functions (=>) which may be mistakenly included in a condition when a comparison such as >= was the intent.

    /*eslint-env es6*/
    
    // Bad
    if (a => 2) {
    }
    
    // Good
    if (a >= 2) {
    }

    The rule can also be configured to discourage the use of parens when they are not required:

    /*eslint-env es6*/
    
    // Bad
    (a) => {}
    
    // Good
    a => {}

    Options

    This rule has a string option and an object one.

    String options are:

    • "always" (default) requires parens around arguments in all cases.
    • "as-needed" allows omitting parens when there is only one argument.

    Object properties for variants of the "as-needed" option:

    • "requireForBlockBody": true modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces).

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint arrow-parens: ["error", "always"]*/
    /*eslint-env es6*/
    
    a => {};
    a => a;
    a => {'\n'};
    a.then(foo => {});
    a.then(foo => a);
    a(foo => { if (true) {} });

    Examples of correct code for this rule with the default "always" option:

    /*eslint arrow-parens: ["error", "always"]*/
    /*eslint-env es6*/
    
    () => {};
    (a) => {};
    (a) => a;
    (a) => {'\n'}
    a.then((foo) => {});
    a.then((foo) => { if (true) {} });

    If Statements

    One of benefits of this option is that it prevents the incorrect use of arrow functions in conditionals:

    /*eslint-env es6*/
    
    var a = 1;
    var b = 2;
    // ...
    if (a => b) {
     console.log('bigger');
    } else {
     console.log('smaller');
    }
    // outputs 'bigger', not smaller as expected

    The contents of the if statement is an arrow function, not a comparison.

    If the arrow function is intentional, it should be wrapped in parens to remove ambiguity.

    /*eslint-env es6*/
    
    var a = 1;
    var b = 0;
    // ...
    if ((a) => b) {
     console.log('truthy value returned');
    } else {
     console.log('falsey value returned');
    }
    // outputs 'truthy value returned'

    The following is another example of this behavior:

    /*eslint-env es6*/
    
    var a = 1, b = 2, c = 3, d = 4;
    var f = a => b ? c: d;
    // f = ?

    f is an arrow function which takes a as an argument and returns the result of b ? c: d.

    This should be rewritten like so:

    /*eslint-env es6*/
    
    var a = 1, b = 2, c = 3, d = 4;
    var f = (a) => b ? c: d;

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint arrow-parens: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    (a) => {};
    (a) => a;
    (a) => {'\n'};
    a.then((foo) => {});
    a.then((foo) => a);
    a((foo) => { if (true) {} });

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint arrow-parens: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    () => {};
    a => {};
    a => a;
    a => {'\n'};
    a.then(foo => {});
    a.then(foo => { if (true) {} });
    (a, b, c) => a;
    (a = 10) => a;
    ([a, b]) => a;
    ({a, b}) => a;

    requireForBlockBody

    Examples of incorrect code for the { "requireForBlockBody": true } option:

    /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
    /*eslint-env es6*/
    
    (a) => a;
    a => {};
    a => {'\n'};
    a.map((x) => x * x);
    a.map(x => {
      return x * x;
    });
    a.then(foo => {});

    Examples of correct code for the { "requireForBlockBody": true } option:

    /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
    /*eslint-env es6*/
    
    (a) => {};
    (a) => {'\n'};
    a => ({});
    () => {};
    a => a;
    a.then((foo) => {});
    a.then((foo) => { if (true) {} });
    a((foo) => { if (true) {} });
    (a, b, c) => a;
    (a = 10) => a;
    ([a, b]) => a;
    ({a, b}) => a;

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function fetchList ({ offset=0, limit=5, start, end, status=0, keyword='', reload=false }) {
      return async (dispatch, getState) => {
        if (reload) {
          dispatch({ type: LIST_POST_RELOADED })
        }
    Severity: Major
    Found in src/client/admin/actions/PostActions.js and 1 other location - About 1 day to fix
    src/client/admin/actions/UserActions.js on lines 226..261

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 291.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    async function fetchAll (offset, limit, start, end, keyword, status) {
      return new Promise((resolve, reject) => {
        const token = getToken()
        const user = jwtDecode(token)
        if (!user || !user.isAdmin) reject('invalid token')
    Severity: Major
    Found in src/client/admin/actions/PostActions.js and 2 other locations - About 1 day to fix
    src/client/admin/actions/AdActions.js on lines 20..45
    src/client/admin/actions/UserActions.js on lines 66..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 256.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    export function markAsSpam (form) {
      return async dispatch => {
        dispatch({ type: MARK_AS_SPAM_STARTED })
        try {
          const token = getToken()
    Severity: Major
    Found in src/client/admin/actions/PostActions.js and 4 other locations - About 5 hrs to fix
    src/client/admin/actions/AdActions.js on lines 143..167
    src/client/admin/actions/AdminActions.js on lines 108..131
    src/client/admin/actions/AdminActions.js on lines 219..243
    src/client/admin/actions/UserActions.js on lines 201..224

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 154.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    async function send (form, token) {
      return new Promise((resolve, reject) => {
        const user = jwtDecode(token)
        if (!user || !user.isAdmin) reject('invalid token')
        request
    Severity: Major
    Found in src/client/admin/actions/PostActions.js and 3 other locations - About 5 hrs to fix
    src/client/admin/actions/AdActions.js on lines 47..64
    src/client/admin/actions/AdminActions.js on lines 51..68
    src/client/admin/actions/UserActions.js on lines 93..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 153.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status