Sign upLogin

lancetw/react-isomorphic-bundle

View on GitHub
Star
src/server/db/dao/usersInfo/usersInfoProvider.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function createOrUpdate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.createOrUpdate = function *(hid, info) {
  const fillable = [
    'uid',
    'cid',
    'ocname',
Severity: Minor
Found in src/server/db/dao/usersInfo/usersInfoProvider.js - About 1 hr to fix

    Unexpected space before *.
    Open

    exports.load = function *(hid) {
    Severity: Minor
    Found in src/server/db/dao/usersInfo/usersInfoProvider.js by eslint

    Enforce spacing around the * in generator functions (generator-star-spacing)

    Generators are a new type of function in ECMAScript 6 that can return multiple values over time. These special functions are indicated by placing an * after the function keyword.

    Here is an example of a generator function:

    /*eslint-env es6*/

function* generator() {
    yield "44";
    yield "55";
}

    This is also valid:

    /*eslint-env es6*/

function *generator() {
    yield "44";
    yield "55";
}

    This is valid as well:

    /*eslint-env es6*/

function * generator() {
    yield "44";
    yield "55";
}

    To keep a sense of consistency when using generators this rule enforces a single position for the *.

    Rule Details

    This rule aims to enforce spacing around the * of generator functions.

    Options

    The rule takes one option, an object, which has two keys before and after having boolean values true or false.

    • before enforces spacing between the * and the function keyword. If it is true, a space is required, otherwise spaces are disallowed.

    In object literal shorthand methods, spacing before the * is not checked, as they lack a function keyword.

    • after enforces spacing between the * and the function name (or the opening parenthesis for anonymous generator functions). If it is true, a space is required, otherwise spaces are disallowed.

    The default is {"before": true, "after": false}.

    An example configuration:

    "generator-star-spacing": ["error", {"before": true, "after": false}]

    And the option has shorthand as a string keyword:

    • {"before": true, "after": false} → "before"
    • {"before": false, "after": true} → "after"
    • {"before": true, "after": true} → "both"
    • {"before": false, "after": false} → "neither"

    An example of shorthand configuration:

    "generator-star-spacing": ["error", "after"]

    Examples

    before

    Examples of correct code for this rule with the "before" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": false}]*/
/*eslint-env es6*/

function *generator() {}

var anonymous = function *() {};

var shorthand = { *generator() {} };

    after

    Examples of correct code for this rule with the "after" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": true}]*/
/*eslint-env es6*/

function* generator() {}

var anonymous = function* () {};

var shorthand = { * generator() {} };

    both

    Examples of correct code for this rule with the "both" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": true}]*/
/*eslint-env es6*/

function * generator() {}

var anonymous = function * () {};

var shorthand = { * generator() {} };

    neither

    Examples of correct code for this rule with the "neither" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": false}]*/
/*eslint-env es6*/

function*generator() {}

var anonymous = function*() {};

var shorthand = { *generator() {} };

    When Not To Use It

    If your project will not be using generators or you are not concerned with spacing consistency, you do not need this rule.

    Further Reading

    Missing space after *.
    Open

    exports.createOrUpdate = function *(hid, info) {
    Severity: Minor
    Found in src/server/db/dao/usersInfo/usersInfoProvider.js by eslint

    Enforce spacing around the * in generator functions (generator-star-spacing)

    Generators are a new type of function in ECMAScript 6 that can return multiple values over time. These special functions are indicated by placing an * after the function keyword.

    Here is an example of a generator function:

    /*eslint-env es6*/

function* generator() {
    yield "44";
    yield "55";
}

    This is also valid:

    /*eslint-env es6*/

function *generator() {
    yield "44";
    yield "55";
}

    This is valid as well:

    /*eslint-env es6*/

function * generator() {
    yield "44";
    yield "55";
}

    To keep a sense of consistency when using generators this rule enforces a single position for the *.

    Rule Details

    This rule aims to enforce spacing around the * of generator functions.

    Options

    The rule takes one option, an object, which has two keys before and after having boolean values true or false.

    • before enforces spacing between the * and the function keyword. If it is true, a space is required, otherwise spaces are disallowed.

    In object literal shorthand methods, spacing before the * is not checked, as they lack a function keyword.

    • after enforces spacing between the * and the function name (or the opening parenthesis for anonymous generator functions). If it is true, a space is required, otherwise spaces are disallowed.

    The default is {"before": true, "after": false}.

    An example configuration:

    "generator-star-spacing": ["error", {"before": true, "after": false}]

    And the option has shorthand as a string keyword:

    • {"before": true, "after": false} → "before"
    • {"before": false, "after": true} → "after"
    • {"before": true, "after": true} → "both"
    • {"before": false, "after": false} → "neither"

    An example of shorthand configuration:

    "generator-star-spacing": ["error", "after"]

    Examples

    before

    Examples of correct code for this rule with the "before" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": false}]*/
/*eslint-env es6*/

function *generator() {}

var anonymous = function *() {};

var shorthand = { *generator() {} };

    after

    Examples of correct code for this rule with the "after" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": true}]*/
/*eslint-env es6*/

function* generator() {}

var anonymous = function* () {};

var shorthand = { * generator() {} };

    both

    Examples of correct code for this rule with the "both" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": true}]*/
/*eslint-env es6*/

function * generator() {}

var anonymous = function * () {};

var shorthand = { * generator() {} };

    neither

    Examples of correct code for this rule with the "neither" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": false}]*/
/*eslint-env es6*/

function*generator() {}

var anonymous = function*() {};

var shorthand = { *generator() {} };

    When Not To Use It

    If your project will not be using generators or you are not concerned with spacing consistency, you do not need this rule.

    Further Reading

    Unexpected space before *.
    Open

    exports.createOrUpdate = function *(hid, info) {
    Severity: Minor
    Found in src/server/db/dao/usersInfo/usersInfoProvider.js by eslint

    Enforce spacing around the * in generator functions (generator-star-spacing)

    Generators are a new type of function in ECMAScript 6 that can return multiple values over time. These special functions are indicated by placing an * after the function keyword.

    Here is an example of a generator function:

    /*eslint-env es6*/

function* generator() {
    yield "44";
    yield "55";
}

    This is also valid:

    /*eslint-env es6*/

function *generator() {
    yield "44";
    yield "55";
}

    This is valid as well:

    /*eslint-env es6*/

function * generator() {
    yield "44";
    yield "55";
}

    To keep a sense of consistency when using generators this rule enforces a single position for the *.

    Rule Details

    This rule aims to enforce spacing around the * of generator functions.

    Options

    The rule takes one option, an object, which has two keys before and after having boolean values true or false.

    • before enforces spacing between the * and the function keyword. If it is true, a space is required, otherwise spaces are disallowed.

    In object literal shorthand methods, spacing before the * is not checked, as they lack a function keyword.

    • after enforces spacing between the * and the function name (or the opening parenthesis for anonymous generator functions). If it is true, a space is required, otherwise spaces are disallowed.

    The default is {"before": true, "after": false}.

    An example configuration:

    "generator-star-spacing": ["error", {"before": true, "after": false}]

    And the option has shorthand as a string keyword:

    • {"before": true, "after": false} → "before"
    • {"before": false, "after": true} → "after"
    • {"before": true, "after": true} → "both"
    • {"before": false, "after": false} → "neither"

    An example of shorthand configuration:

    "generator-star-spacing": ["error", "after"]

    Examples

    before

    Examples of correct code for this rule with the "before" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": false}]*/
/*eslint-env es6*/

function *generator() {}

var anonymous = function *() {};

var shorthand = { *generator() {} };

    after

    Examples of correct code for this rule with the "after" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": true}]*/
/*eslint-env es6*/

function* generator() {}

var anonymous = function* () {};

var shorthand = { * generator() {} };

    both

    Examples of correct code for this rule with the "both" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": true}]*/
/*eslint-env es6*/

function * generator() {}

var anonymous = function * () {};

var shorthand = { * generator() {} };

    neither

    Examples of correct code for this rule with the "neither" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": false}]*/
/*eslint-env es6*/

function*generator() {}

var anonymous = function*() {};

var shorthand = { *generator() {} };

    When Not To Use It

    If your project will not be using generators or you are not concerned with spacing consistency, you do not need this rule.

    Further Reading

    Missing space after *.
    Open

    exports.load = function *(hid) {
    Severity: Minor
    Found in src/server/db/dao/usersInfo/usersInfoProvider.js by eslint

    Enforce spacing around the * in generator functions (generator-star-spacing)

    Generators are a new type of function in ECMAScript 6 that can return multiple values over time. These special functions are indicated by placing an * after the function keyword.

    Here is an example of a generator function:

    /*eslint-env es6*/

function* generator() {
    yield "44";
    yield "55";
}

    This is also valid:

    /*eslint-env es6*/

function *generator() {
    yield "44";
    yield "55";
}

    This is valid as well:

    /*eslint-env es6*/

function * generator() {
    yield "44";
    yield "55";
}

    To keep a sense of consistency when using generators this rule enforces a single position for the *.

    Rule Details

    This rule aims to enforce spacing around the * of generator functions.

    Options

    The rule takes one option, an object, which has two keys before and after having boolean values true or false.

    • before enforces spacing between the * and the function keyword. If it is true, a space is required, otherwise spaces are disallowed.

    In object literal shorthand methods, spacing before the * is not checked, as they lack a function keyword.

    • after enforces spacing between the * and the function name (or the opening parenthesis for anonymous generator functions). If it is true, a space is required, otherwise spaces are disallowed.

    The default is {"before": true, "after": false}.

    An example configuration:

    "generator-star-spacing": ["error", {"before": true, "after": false}]

    And the option has shorthand as a string keyword:

    • {"before": true, "after": false} → "before"
    • {"before": false, "after": true} → "after"
    • {"before": true, "after": true} → "both"
    • {"before": false, "after": false} → "neither"

    An example of shorthand configuration:

    "generator-star-spacing": ["error", "after"]

    Examples

    before

    Examples of correct code for this rule with the "before" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": false}]*/
/*eslint-env es6*/

function *generator() {}

var anonymous = function *() {};

var shorthand = { *generator() {} };

    after

    Examples of correct code for this rule with the "after" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": true}]*/
/*eslint-env es6*/

function* generator() {}

var anonymous = function* () {};

var shorthand = { * generator() {} };

    both

    Examples of correct code for this rule with the "both" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": true}]*/
/*eslint-env es6*/

function * generator() {}

var anonymous = function * () {};

var shorthand = { * generator() {} };

    neither

    Examples of correct code for this rule with the "neither" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": false}]*/
/*eslint-env es6*/

function*generator() {}

var anonymous = function*() {};

var shorthand = { *generator() {} };

    When Not To Use It

    If your project will not be using generators or you are not concerned with spacing consistency, you do not need this rule.

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    exports.load = function *(hid) {
  const id = +hashids.decode(hid)
  if (!isFinite(id)) return {}
  return yield models.usersInfo.findOne({
    where: { uid: id },
    Severity: Major
    Found in src/server/db/dao/usersInfo/usersInfoProvider.js and 2 other locations - About 2 hrs to fix
    src/server/db/dao/promotions/promotionsProvider.js on lines 12..19
    src/server/db/dao/users/usersProvider.js on lines 37..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Expected empty line after require statement not followed by another require.
    Open

    const models = require('src/server/db/models')
    Severity: Minor
    Found in src/server/db/dao/usersInfo/usersInfoProvider.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Import in body of module; reorder to top.
    Open

    import { isFinite } from 'lodash'
    Severity: Minor
    Found in src/server/db/dao/usersInfo/usersInfoProvider.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status