lancetw/react-isomorphic-bundle

View on GitHub
src/server/services/v1/searches.js

Summary

Maintainability
A
1 hr
Test Coverage

Function index has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  index: function *(next) {
    const { scope } = this.request.query

    if (scope === 'post') {
      const status = 0
Severity: Minor
Found in src/server/services/v1/searches.js - About 1 hr to fix

    Missing space after *.
    Open

      index: function *(next) {
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    Enforce spacing around the * in generator functions (generator-star-spacing)

    Generators are a new type of function in ECMAScript 6 that can return multiple values over time. These special functions are indicated by placing an * after the function keyword.

    Here is an example of a generator function:

    /*eslint-env es6*/
    
    function* generator() {
        yield "44";
        yield "55";
    }

    This is also valid:

    /*eslint-env es6*/
    
    function *generator() {
        yield "44";
        yield "55";
    }

    This is valid as well:

    /*eslint-env es6*/
    
    function * generator() {
        yield "44";
        yield "55";
    }

    To keep a sense of consistency when using generators this rule enforces a single position for the *.

    Rule Details

    This rule aims to enforce spacing around the * of generator functions.

    Options

    The rule takes one option, an object, which has two keys before and after having boolean values true or false.

    • before enforces spacing between the * and the function keyword. If it is true, a space is required, otherwise spaces are disallowed.

    In object literal shorthand methods, spacing before the * is not checked, as they lack a function keyword.

    • after enforces spacing between the * and the function name (or the opening parenthesis for anonymous generator functions). If it is true, a space is required, otherwise spaces are disallowed.

    The default is {"before": true, "after": false}.

    An example configuration:

    "generator-star-spacing": ["error", {"before": true, "after": false}]

    And the option has shorthand as a string keyword:

    • {"before": true, "after": false}"before"
    • {"before": false, "after": true}"after"
    • {"before": true, "after": true}"both"
    • {"before": false, "after": false}"neither"

    An example of shorthand configuration:

    "generator-star-spacing": ["error", "after"]

    Examples

    before

    Examples of correct code for this rule with the "before" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": false}]*/
    /*eslint-env es6*/
    
    function *generator() {}
    
    var anonymous = function *() {};
    
    var shorthand = { *generator() {} };

    after

    Examples of correct code for this rule with the "after" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": true}]*/
    /*eslint-env es6*/
    
    function* generator() {}
    
    var anonymous = function* () {};
    
    var shorthand = { * generator() {} };

    both

    Examples of correct code for this rule with the "both" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": true}]*/
    /*eslint-env es6*/
    
    function * generator() {}
    
    var anonymous = function * () {};
    
    var shorthand = { * generator() {} };

    neither

    Examples of correct code for this rule with the "neither" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": false}]*/
    /*eslint-env es6*/
    
    function*generator() {}
    
    var anonymous = function*() {};
    
    var shorthand = { *generator() {} };

    When Not To Use It

    If your project will not be using generators or you are not concerned with spacing consistency, you do not need this rule.

    Further Reading

    Unexpected space before *.
    Open

      index: function *(next) {
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    Enforce spacing around the * in generator functions (generator-star-spacing)

    Generators are a new type of function in ECMAScript 6 that can return multiple values over time. These special functions are indicated by placing an * after the function keyword.

    Here is an example of a generator function:

    /*eslint-env es6*/
    
    function* generator() {
        yield "44";
        yield "55";
    }

    This is also valid:

    /*eslint-env es6*/
    
    function *generator() {
        yield "44";
        yield "55";
    }

    This is valid as well:

    /*eslint-env es6*/
    
    function * generator() {
        yield "44";
        yield "55";
    }

    To keep a sense of consistency when using generators this rule enforces a single position for the *.

    Rule Details

    This rule aims to enforce spacing around the * of generator functions.

    Options

    The rule takes one option, an object, which has two keys before and after having boolean values true or false.

    • before enforces spacing between the * and the function keyword. If it is true, a space is required, otherwise spaces are disallowed.

    In object literal shorthand methods, spacing before the * is not checked, as they lack a function keyword.

    • after enforces spacing between the * and the function name (or the opening parenthesis for anonymous generator functions). If it is true, a space is required, otherwise spaces are disallowed.

    The default is {"before": true, "after": false}.

    An example configuration:

    "generator-star-spacing": ["error", {"before": true, "after": false}]

    And the option has shorthand as a string keyword:

    • {"before": true, "after": false}"before"
    • {"before": false, "after": true}"after"
    • {"before": true, "after": true}"both"
    • {"before": false, "after": false}"neither"

    An example of shorthand configuration:

    "generator-star-spacing": ["error", "after"]

    Examples

    before

    Examples of correct code for this rule with the "before" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": false}]*/
    /*eslint-env es6*/
    
    function *generator() {}
    
    var anonymous = function *() {};
    
    var shorthand = { *generator() {} };

    after

    Examples of correct code for this rule with the "after" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": true}]*/
    /*eslint-env es6*/
    
    function* generator() {}
    
    var anonymous = function* () {};
    
    var shorthand = { * generator() {} };

    both

    Examples of correct code for this rule with the "both" option:

    /*eslint generator-star-spacing: ["error", {"before": true, "after": true}]*/
    /*eslint-env es6*/
    
    function * generator() {}
    
    var anonymous = function * () {};
    
    var shorthand = { * generator() {} };

    neither

    Examples of correct code for this rule with the "neither" option:

    /*eslint generator-star-spacing: ["error", {"before": false, "after": false}]*/
    /*eslint-env es6*/
    
    function*generator() {}
    
    var anonymous = function*() {};
    
    var shorthand = { *generator() {} };

    When Not To Use It

    If your project will not be using generators or you are not concerned with spacing consistency, you do not need this rule.

    Further Reading

    Unexpected function expression.
    Open

            .end(function (err, res) {
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    Suggest using arrow functions as callbacks. (prefer-arrow-callback)

    Arrow functions are suited to callbacks, because:

    • this keywords in arrow functions bind to the upper scope's.
    • The notation of the arrow function is shorter than function expression's.

    Rule Details

    This rule is aimed to flag usage of function expressions in an argument list.

    The following patterns are considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    
    foo(function(a) { return a; });
    foo(function() { return this.a; }.bind(this));

    The following patterns are not considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    /*eslint-env es6*/
    
    foo(a => a);
    foo(function*() { yield; });
    
    // this is not a callback.
    var foo = function foo(a) { return a; };
    
    // using `this` without `.bind(this)`.
    foo(function() { return this.a; });
    
    // recursively.
    foo(function bar(n) { return n && n + bar(n - 1); });

    Options

    This rule takes one optional argument, an object which is an options object.

    allowNamedFunctions

    This is a boolean option and it is false by default. When set to true, the rule doesn't warn on named functions used as callbacks.

    Examples of correct code for the { "allowNamedFunctions": true } option:

    /*eslint prefer-arrow-callback: ["error", { "allowNamedFunctions": true }]*/
    
    foo(function bar() {});

    allowUnboundThis

    This is a boolean option and it is true by default. When set to false, this option allows the use of this without restriction and checks for dynamically assigned this values such as when using Array.prototype.map with a context argument. Normally, the rule will flag the use of this whenever a function does not use bind() to specify the value of this constantly.

    Examples of incorrect code for the { "allowUnboundThis": false } option:

    /*eslint prefer-arrow-callback: ["error", { "allowUnboundThis": false }]*/
    /*eslint-env es6*/
    
    foo(function() { this.a; });
    
    foo(function() { (() => this); });
    
    someArray.map(function (itm) { return this.doSomething(itm); }, someObject);

    When Not To Use It

    This rule should not be used in ES3/5 environments.

    In ES2015 (ES6) or later, if you don't want to be notified about function expressions in an argument list, you can safely disable this rule. Source: http://eslint.org/docs/rules/

    Requires a space before '}'.
    Open

          } catch (err) {/* error */}
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    Disallow or enforce spaces inside of single line blocks (block-spacing)

    Rule Details

    This rule enforces consistent spacing inside single-line blocks.

    Options

    This rule has a string option:

    • "always" (default) requires one or more spaces
    • "never" disallows spaces

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint block-spacing: "error"*/
    
    function foo() {return true;}
    if (foo) { bar = 0;}

    Examples of correct code for this rule with the default "always" option:

    /*eslint block-spacing: "error"*/
    
    function foo() { return true; }
    if (foo) { bar = 0; }

    never

    Examples of incorrect code for this rule with the "never" option:

    /*eslint block-spacing: ["error", "never"]*/
    
    function foo() { return true; }
    if (foo) { bar = 0;}

    Examples of correct code for this rule with the "never" option:

    /*eslint block-spacing: ["error", "never"]*/
    
    function foo() {return true;}
    if (foo) {bar = 0;}

    When Not To Use It

    If you don't want to be notified about spacing style inside of blocks, you can safely disable this rule. Source: http://eslint.org/docs/rules/

    Requires a space after '{'.
    Open

          } catch (err) {/* error */}
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    Disallow or enforce spaces inside of single line blocks (block-spacing)

    Rule Details

    This rule enforces consistent spacing inside single-line blocks.

    Options

    This rule has a string option:

    • "always" (default) requires one or more spaces
    • "never" disallows spaces

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint block-spacing: "error"*/
    
    function foo() {return true;}
    if (foo) { bar = 0;}

    Examples of correct code for this rule with the default "always" option:

    /*eslint block-spacing: "error"*/
    
    function foo() { return true; }
    if (foo) { bar = 0; }

    never

    Examples of incorrect code for this rule with the "never" option:

    /*eslint block-spacing: ["error", "never"]*/
    
    function foo() { return true; }
    if (foo) { bar = 0;}

    Examples of correct code for this rule with the "never" option:

    /*eslint block-spacing: ["error", "never"]*/
    
    function foo() {return true;}
    if (foo) {bar = 0;}

    When Not To Use It

    If you don't want to be notified about spacing style inside of blocks, you can safely disable this rule. Source: http://eslint.org/docs/rules/

    Trailing spaces not allowed.
    Open

        
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    disallow trailing whitespace at the end of lines (no-trailing-spaces)

    Sometimes in the course of editing files, you can end up with extra whitespace at the end of lines. These whitespace differences can be picked up by source control systems and flagged as diffs, causing frustration for developers. While this extra whitespace causes no functional issues, many code conventions require that trailing spaces be removed before check-in.

    Rule Details

    This rule disallows trailing whitespace (spaces, tabs, and other Unicode whitespace characters) at the end of lines.

    Examples of incorrect code for this rule:

    /*eslint no-trailing-spaces: "error"*/
    
    var foo = 0;//•••••
    var baz = 5;//••
    //•••••

    Examples of correct code for this rule:

    /*eslint no-trailing-spaces: "error"*/
    
    var foo = 0;
    var baz = 5;

    Options

    This rule has an object option:

    • "skipBlankLines": false (default) disallows trailing whitespace on empty lines
    • "skipBlankLines": true allows trailing whitespace on empty lines

    skipBlankLines

    Examples of correct code for this rule with the { "skipBlankLines": true } option:

    /*eslint no-trailing-spaces: ["error", { "skipBlankLines": true }]*/
    
    var foo = 0;
    var baz = 5;
    //•••••

    Source: http://eslint.org/docs/rules/

    Expected property shorthand.
    Open

            .query({ address: address })
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    Expected method shorthand.
    Open

      index: function *(next) {
    Severity: Minor
    Found in src/server/services/v1/searches.js by eslint

    Require Object Literal Shorthand Syntax (object-shorthand)

    EcmaScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

    Here are a few common examples using the ES5 syntax:

    // properties
    var foo = {
        x: x,
        y: y,
        z: z,
    };
    
    // methods
    var foo = {
        a: function() {},
        b: function() {}
    };

    Now here are ES6 equivalents:

    /*eslint-env es6*/
    
    // properties
    var foo = {x, y, z};
    
    // methods
    var foo = {
        a() {},
        b() {}
    };

    Rule Details

    This rule enforces the use of the shorthand syntax. This applies to all methods (including generators) defined in object literals and any properties defined where the key name matches name of the assigned variable.

    Each of the following properties would warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w: function() {},
        x: function *() {},
        [y]: function() {},
        z: z
    };

    In that case the expected syntax would have been:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        w() {},
        *x() {},
        [y]() {},
        z
    };

    This rule does not flag arrow functions inside of object literals. The following will not warn:

    /*eslint object-shorthand: "error"*/
    /*eslint-env es6*/
    
    var foo = {
        x: (y) => y
    };

    Options

    The rule takes an option which specifies when it should be applied. It can be set to one of the following values:

    • "always" (default) expects that the shorthand will be used whenever possible.
    • "methods" ensures the method shorthand is used (also applies to generators).
    • "properties" ensures the property shorthand is used (where the key and variable name match).
    • "never" ensures that no property or method shorthand is used in any object literal.
    • "consistent" ensures that either all shorthand or all longform will be used in an object literal.
    • "consistent-as-needed" ensures that either all shorthand or all longform will be used in an object literal, but ensures all shorthand whenever possible.

    You can set the option in configuration like this:

    {
        "object-shorthand": ["error", "always"]
    }

    Additionally, the rule takes an optional object configuration:

    • "avoidQuotes": true indicates that longform syntax is preferred whenever the object key is a string literal (default: false). Note that this option can only be enabled when the string option is set to "always", "methods", or "properties".
    • "ignoreConstructors": true can be used to prevent the rule from reporting errors for constructor functions. (By default, the rule treats constructors the same way as other functions.) Note that this option can only be enabled when the string option is set to "always" or "methods".
    • "avoidExplicitReturnArrows": true indicates that methods are preferred over explicit-return arrow functions for function properties. (By default, the rule allows either of these.) Note that this option can only be enabled when the string option is set to "always" or "methods".

    avoidQuotes

    {
        "object-shorthand": ["error", "always", { "avoidQuotes": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz"() {}
    };

    Example of correct code for this rule with the "always", { "avoidQuotes": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidQuotes": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        "bar-baz": function() {},
        "qux": qux
    };

    ignoreConstructors

    {
        "object-shorthand": ["error", "always", { "ignoreConstructors": true }]
    }

    Example of correct code for this rule with the "always", { "ignoreConstructors": true } option:

    /*eslint object-shorthand: ["error", "always", { "ignoreConstructors": true }]*/
    /*eslint-env es6*/
    
    var foo = {
        ConstructorFunction: function() {}
    };

    avoidExplicitReturnArrows

    {
        "object-shorthand": ["error", "always", { "avoidExplicitReturnArrows": true }]
    }

    Example of incorrect code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo: (bar, baz) => {
        return bar + baz;
      },
    
      qux: (foobar) => {
        return foobar * 2;
      }
    };

    Example of correct code for this rule with the "always", { "avoidExplicitReturnArrows": true } option:

    /*eslint object-shorthand: ["error", "always", { "avoidExplicitReturnArrows": true }]*/
    /*eslint-env es6*/
    
    var foo = {
      foo(bar, baz) {
        return bar + baz;
      },
    
      qux: foobar => foobar * 2
    };

    Example of incorrect code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a,
        b: "foo",
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint object-shorthand: [2, "consistent"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: "foo"
    };
    
    var bar = {
        a,
        b,
    };

    Example of incorrect code with the "consistent-as-needed" option, which is very similar to "consistent":

    /*eslint object-shorthand: [2, "consistent-as-needed"]*/
    /*eslint-env es6*/
    
    var foo = {
        a: a,
        b: b,
    };

    When Not To Use It

    Anyone not yet in an ES6 environment would not want to apply this rule. Others may find the terseness of the shorthand syntax harder to read and may not want to encourage it with this rule.

    Further Reading

    Object initializer - MDN Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status