lancetw/react-isomorphic-bundle

View on GitHub
src/shared/components/PostDetailHandler.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function render has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const { dispatch, _T } = this.props
    const { getState } = this.context.store
    const { detail } = getState().post
    const { place } = getState().map
Severity: Minor
Found in src/shared/components/PostDetailHandler.js - About 1 hr to fix

    Unexpected function expression.
    Open

        files && files.map(function (file) {

    Suggest using arrow functions as callbacks. (prefer-arrow-callback)

    Arrow functions are suited to callbacks, because:

    • this keywords in arrow functions bind to the upper scope's.
    • The notation of the arrow function is shorter than function expression's.

    Rule Details

    This rule is aimed to flag usage of function expressions in an argument list.

    The following patterns are considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    
    foo(function(a) { return a; });
    foo(function() { return this.a; }.bind(this));

    The following patterns are not considered problems:

    /*eslint prefer-arrow-callback: "error"*/
    /*eslint-env es6*/
    
    foo(a => a);
    foo(function*() { yield; });
    
    // this is not a callback.
    var foo = function foo(a) { return a; };
    
    // using `this` without `.bind(this)`.
    foo(function() { return this.a; });
    
    // recursively.
    foo(function bar(n) { return n && n + bar(n - 1); });

    Options

    This rule takes one optional argument, an object which is an options object.

    allowNamedFunctions

    This is a boolean option and it is false by default. When set to true, the rule doesn't warn on named functions used as callbacks.

    Examples of correct code for the { "allowNamedFunctions": true } option:

    /*eslint prefer-arrow-callback: ["error", { "allowNamedFunctions": true }]*/
    
    foo(function bar() {});

    allowUnboundThis

    This is a boolean option and it is true by default. When set to false, this option allows the use of this without restriction and checks for dynamically assigned this values such as when using Array.prototype.map with a context argument. Normally, the rule will flag the use of this whenever a function does not use bind() to specify the value of this constantly.

    Examples of incorrect code for the { "allowUnboundThis": false } option:

    /*eslint prefer-arrow-callback: ["error", { "allowUnboundThis": false }]*/
    /*eslint-env es6*/
    
    foo(function() { this.a; });
    
    foo(function() { (() => this); });
    
    someArray.map(function (itm) { return this.doSomething(itm); }, someObject);

    When Not To Use It

    This rule should not be used in ES3/5 environments.

    In ES2015 (ES6) or later, if you don't want to be notified about function expressions in an argument list, you can safely disable this rule. Source: http://eslint.org/docs/rules/

    Unnecessarily quoted property 'property' found.
    Open

        meta.push({ 'property': 'article:publisher', 'content': 'https://www.facebook.com/CCNDA/' })

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Unnecessarily quoted property 'property' found.
    Open

          'property': 'og:image',

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Expected to return a value in function.
    Open

        files && files.map(function (file) {

    Enforces return statements in callbacks of array's methods (array-callback-return)

    Array has several methods for filtering, mapping, and folding. If we forget to write return statement in a callback of those, it's probably a mistake.

    // example: convert ['a', 'b', 'c'] --> {a: 0, b: 1, c: 2}
    var indexMap = myArray.reduce(function(memo, item, index) {
      memo[item] = index;
    }, {}); // Error: cannot set property 'b' of undefined

    This rule enforces usage of return statement in callbacks of array's methods.

    Rule Details

    This rule finds callback functions of the following methods, then checks usage of return statement.

    Examples of incorrect code for this rule:

    /*eslint array-callback-return: "error"*/
    
    var indexMap = myArray.reduce(function(memo, item, index) {
        memo[item] = index;
    }, {});
    
    var foo = Array.from(nodes, function(node) {
        if (node.tagName === "DIV") {
            return true;
        }
    });
    
    var bar = foo.filter(function(x) {
        if (x) {
            return true;
        } else {
            return;
        }
    });

    Examples of correct code for this rule:

    /*eslint array-callback-return: "error"*/
    
    var indexMap = myArray.reduce(function(memo, item, index) {
        memo[item] = index;
        return memo;
    }, {});
    
    var foo = Array.from(nodes, function(node) {
        if (node.tagName === "DIV") {
            return true;
        }
        return false;
    });
    
    var bar = foo.map(node => node.getAttribute("id"));

    Known Limitations

    This rule checks callback functions of methods with the given names, even if the object which has the method is not an array.

    When Not To Use It

    If you don't want to warn about usage of return statement in callbacks of array's methods, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

    Unnecessarily quoted property 'content' found.
    Open

        meta.push({ 'property': 'og:type', 'content': 'article' })

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Unnecessarily quoted property 'content' found.
    Open

              'content': `${protocol}://${host}/uploads/${file}`

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Unnecessarily quoted property 'property' found.
    Open

        meta.push({ 'property': 'og:type', 'content': 'article' })

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Unnecessarily quoted property 'content' found.
    Open

          'content': `${protocol}://${host}/images/oursevents@2x.png`

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Unnecessarily quoted property 'property' found.
    Open

              'property': 'og:image',

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Unnecessarily quoted property 'content' found.
    Open

        meta.push({ 'property': 'article:publisher', 'content': 'https://www.facebook.com/CCNDA/' })

    require quotes around object literal property names (quote-props)

    Object literal property names can be defined in two ways: using literals or using strings. For example, these two objects are equivalent:

    var object1 = {
        property: true
    };
    
    var object2 = {
        "property": true
    };

    In many cases, it doesn't matter if you choose to use an identifier instead of a string or vice-versa. Even so, you might decide to enforce a consistent style in your code.

    There are, however, some occasions when you must use quotes:

    1. If you are using an ECMAScript 3 JavaScript engine (such as IE8) and you want to use a keyword (such as if) as a property name. This restriction was removed in ECMAScript 5.
    2. You want to use a non-identifier character in your property name, such as having a property with a space like "one two".

    Another example where quotes do matter is when using numeric literals as property keys:

    var object = {
        1e2: 1,
        100: 2
    };

    This may look alright at first sight, but this code in fact throws a syntax error in ECMAScript 5 strict mode. This happens because 1e2 and 100 are coerced into strings before getting used as the property name. Both String(1e2) and String(100) happen to be equal to "100", which causes the "Duplicate data property in object literal not allowed in strict mode" error. Issues like that can be tricky to debug, so some prefer to require quotes around all property names.

    Rule Details

    This rule requires quotes around object literal property names.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "always" (default) requires quotes around all object literal property names
    • "as-needed" disallows quotes around object literal property names that are not strictly required
    • "consistent" enforces a consistent quote style requires quotes around object literal property names
    • "consistent-as-needed" requires quotes around all object literal property names if any name strictly requires quotes, otherwise disallows quotes around object property names

    Object option:

    • "keywords": true requires quotes around language keywords used as object property names (only applies when using as-needed or consistent-as-needed)
    • "unnecessary": true (default) disallows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "unnecessary": false allows quotes around object literal property names that are not strictly required (only applies when using as-needed)
    • "numbers": true requires quotes around numbers used as object property names (only applies when using as-needed)

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    
    var object = {
        foo: "bar",
        baz: 42,
        "qux-lorem": true
    };

    Examples of correct code for this rule with the default "always" option:

    /*eslint quote-props: ["error", "always"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    
    var object = {
        "a": 0,
        "0": 0,
        "true": 0,
        "null": 0
    };

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint quote-props: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    var object1 = {
        "a-b": 0,
        "0x0": 0,
        "1e2": 0
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42,
        true: 0,
        0: 0,
        'qux-lorem': true
    };
    
    var object3 = {
        foo() {
            return;
        }
    };

    consistent

    Examples of incorrect code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        baz: 42
    };

    Examples of correct code for this rule with the "consistent" option:

    /*eslint quote-props: ["error", "consistent"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };
    
    var object3 = {
        foo: 'bar',
        baz: 42
    };

    consistent-as-needed

    Examples of incorrect code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        foo: "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        'foo': 'bar',
        'baz': 42
    };

    Examples of correct code for this rule with the "consistent-as-needed" option:

    /*eslint quote-props: ["error", "consistent-as-needed"]*/
    
    var object1 = {
        "foo": "bar",
        "baz": 42,
        "qux-lorem": true
    };
    
    var object2 = {
        foo: 'bar',
        baz: 42
    };

    keywords

    Examples of additional incorrect code for this rule with the "as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true }]*/
    
    var x = {
        while: 1,
        volatile: "foo"
    };

    Examples of additional incorrect code for this rule with the "consistent-as-needed", { "keywords": true } options:

    /*eslint quote-props: ["error", "consistent-as-needed", { "keywords": true }]*/
    
    var x = {
        "prop": 1,
        "bar": "foo"
    };

    unnecessary

    Examples of additional correct code for this rule with the "as-needed", { "unnecessary": false } options:

    /*eslint quote-props: ["error", "as-needed", { "keywords": true, "unnecessary": false }]*/
    
    var x = {
        "while": 1,
        "foo": "bar"  // Would normally have caused a warning
    };

    numbers

    Examples of additional incorrect code for this rule with the "as-needed", { "numbers": true } options:

    /*eslint quote-props: ["error", "as-needed", { "numbers": true }]*/
    
    var x = {
        100: 1
    }

    When Not To Use It

    If you don't care if property names are consistently wrapped in quotes or not, and you don't target legacy ES3 environments, turn this rule off.

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export default connect(state => ({
      auth: state.auth,
      post: state.post,
      moreList: state.cprop,
      map: state.map
    Severity: Major
    Found in src/shared/components/PostDetailHandler.js and 1 other location - About 1 hr to fix
    src/shared/components/OgHandler.js on lines 97..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Absolute imports should come before relative imports.
    Open

    import connectI18n from 'shared/components/addon/connect-i18n'

    For more information visit Source: http://eslint.org/docs/rules/

    JSX not allowed in files with extension '.js'
    Open

          <div>

    For more information visit Source: http://eslint.org/docs/rules/

    Prop type object is forbidden
    Open

        location: PropTypes.object.isRequired,

    For more information visit Source: http://eslint.org/docs/rules/

    The closing bracket must be aligned with the line containing the opening tag (expected column 9 on the next line)
    Open

              title={place ? `${title} | ${place}` : `${title} | ${defaultTitle}`} meta={meta} />

    For more information visit Source: http://eslint.org/docs/rules/

    Absolute imports should come before relative imports.
    Open

    import { bindActionCreators } from 'redux'

    For more information visit Source: http://eslint.org/docs/rules/

    Absolute imports should come before relative imports.
    Open

    import { connect } from 'react-redux'

    For more information visit Source: http://eslint.org/docs/rules/

    Absolute imports should come before relative imports.
    Open

    import { getFileExt, checkImageFile } from 'shared/utils/file-utils'

    For more information visit Source: http://eslint.org/docs/rules/

    Prop type object is forbidden
    Open

        params: PropTypes.object.isRequired,

    For more information visit Source: http://eslint.org/docs/rules/

    Prop type object is forbidden
    Open

        post: PropTypes.object.isRequired,

    For more information visit Source: http://eslint.org/docs/rules/

    Absolute imports should come before relative imports.
    Open

    import counterpart from 'counterpart'

    For more information visit Source: http://eslint.org/docs/rules/

    'post' PropType is defined but prop is never used
    Open

        post: PropTypes.object.isRequired,

    For more information visit Source: http://eslint.org/docs/rules/

    Prop type object is forbidden
    Open

        auth: PropTypes.object.isRequired,

    For more information visit Source: http://eslint.org/docs/rules/

    Absolute imports should come before relative imports.
    Open

    import { tongwenAuto } from 'shared/utils/tongwen'

    For more information visit Source: http://eslint.org/docs/rules/

    Absolute imports should come before relative imports.
    Open

    import Helmet from 'react-helmet'

    For more information visit Source: http://eslint.org/docs/rules/

    The closing bracket must be aligned with the line containing the opening tag (expected column 9 on the next line)
    Open

              {...this.props} />

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status