Sign upLogin

lancetw/react-isomorphic-bundle

View on GitHub
Star
src/shared/components/PostEditRingHandler.js

Summary

Maintainability
D
2 days
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  componentWillMount () {
    const { dispatch } = this.props
    const { store: { resolver, getState } } = this.context

    dispatch(updateTitle('title.post'))
Severity: Major
Found in src/shared/components/PostEditRingHandler.js and 1 other location - About 1 day to fix
src/shared/components/PostEditHandler.js on lines 40..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 318.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export default connect(state => ({
  auth: state.auth,
  post: state.post,
  upload: state.upload,
  map: state.map
Severity: Major
Found in src/shared/components/PostEditRingHandler.js and 1 other location - About 3 hrs to fix
src/shared/components/PostEditHandler.js on lines 96..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  static propTypes = {
    dispatch: PropTypes.func.isRequired,
    params: PropTypes.object.isRequired,
    auth: PropTypes.object.isRequired,
    _T: PropTypes.func.isRequired,
Severity: Major
Found in src/shared/components/PostEditRingHandler.js and 4 other locations - About 1 hr to fix
src/shared/components/LoginComponent.js on lines 10..16
src/shared/components/ManageHandler.js on lines 15..21
src/shared/components/PostEditHandler.js on lines 21..27
src/shared/components/TWBLoginComponent.js on lines 10..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Absolute imports should come before relative imports.
Open

import { connect } from 'react-redux'
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

} from 'shared/utils/forms'
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import connectI18n from 'shared/components/addon/connect-i18n'
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Prop type object is forbidden
Open

    params: PropTypes.object.isRequired,
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import Helmet from 'react-helmet'
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

The closing bracket must be aligned with the line containing the opening tag (expected column 9 on the next line)
Open

          regFormType={RegForm(defaultLocale)} />
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import { bindActionCreators } from 'redux'
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Prop type object is forbidden
Open

    auth: PropTypes.object.isRequired,
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

JSX not allowed in files with extension '.js'
Open

      <div>
Severity: Minor
Found in src/shared/components/PostEditRingHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status