Sign upLogin

lancetw/react-isomorphic-bundle

View on GitHub
Star
src/shared/components/WallHandler.js

Summary

Maintainability
B
4 hrs
Test Coverage

Useless constructor.
Open

  constructor (props) {
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

Disallow unnecessary constructor (no-useless-constructor)

ES2015 provides a default class constructor if one is not specified. As such, it is unnecessary to provide an empty constructor or one that simply delegates into its parent class, as in the following examples:

class A {
    constructor () {
    }
}

class A extends B {
    constructor (value) {
      super(value);
    }
}

Rule Details

This rule flags class constructors that can be safely removed without changing how the class works.

Examples

Examples of incorrect code for this rule:

/*eslint no-useless-constructor: "error"*/
/*eslint-env es6*/

class A {
    constructor () {
    }
}

class A extends B {
    constructor (...args) {
      super(...args);
    }
}

Examples of correct code for this rule:

/*eslint no-useless-constructor: "error"*/

class A { }

class A {
    constructor () {
        doSomething();
    }
}

class A extends B {
    constructor() {
        super('foo');
    }
}

class A extends B {
    constructor() {
        super();
        doSomething();
    }
}

When Not To Use It

If you don't want to be notified about unnecessary constructors, you can safely disable this rule. Source: http://eslint.org/docs/rules/

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  static propTypes = {
    dispatch: PropTypes.func.isRequired,
    _T: PropTypes.func.isRequired,
    defaultLocale: PropTypes.string.isRequired,
    params: PropTypes.object.isRequired,
Severity: Major
Found in src/shared/components/WallHandler.js and 2 other locations - About 2 hrs to fix
src/shared/components/WallCpropHandler.js on lines 16..23
src/shared/components/addon/image-upload.js on lines 9..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    return (
      <div>
        <Helmet title={`${title} | ${defaultTitle}`} />
        <Wall
          {...this.props}
Severity: Major
Found in src/shared/components/WallHandler.js and 2 other locations - About 1 hr to fix
src/shared/components/SearchHandler.js on lines 43..50
src/shared/components/WallCpropHandler.js on lines 65..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Absolute imports should come before relative imports.
Open

import { at } from 'lodash'
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import { originLocaleName } from 'shared/utils/locale-utils'
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import { bindActionCreators } from 'redux'
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import { connect } from 'react-redux'
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import Helmet from 'react-helmet'
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

JSX not allowed in files with extension '.js'
Open

      <div>
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Prop type object is forbidden
Open

    params: PropTypes.object.isRequired,
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Prop type object is forbidden
Open

    auth: PropTypes.object.isRequired
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import { PostPropArray } from 'shared/utils/forms'
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Prop type object is forbidden
Open

    post: PropTypes.object.isRequired,
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

The closing bracket must be aligned with the line containing the opening tag (expected column 9 on the next line)
Open

          loadFunc={this.loadFunc} />
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Absolute imports should come before relative imports.
Open

import connectI18n from 'shared/components/addon/connect-i18n'
Severity: Minor
Found in src/shared/components/WallHandler.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status