Sign upLogin

laundree/laundree

View on GitHub
Star
src/websocket/socket_io.js

Summary

Maintainability
D
2 days
Test Coverage

File socket_io.js has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow
import connectMongoose from '../db/mongoose'
import socketIo from 'socket.io'
import UserHandler from '../handlers/user'
import LaundryHandler from '../handlers/laundry'
Severity: Minor
Found in src/websocket/socket_io.js - About 5 hrs to fix

Function setupAdminFunctions has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupAdminFunctions (socket) {
  debug('Adding admin functions')
  defineSocketFunction(
    socket,
    'listLaundries',
Severity: Major
Found in src/websocket/socket_io.js - About 2 hrs to fix

Function setupFunctions has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupFunctions (socket) {
  defineLaundrySocketFunction(
    socket,
    'listBookingsInTime',
    async (laundry, fromO, toO) => {
Severity: Major
Found in src/websocket/socket_io.js - About 2 hrs to fix

Function setupUser has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupUser (socket, userUpdateEmitter, u: ?UserHandler) {
  const user = u
  if (!user) {
    debug('Found no user, will not setup')
    return
Severity: Minor
Found in src/websocket/socket_io.js - About 1 hr to fix

Function authenticateSocket has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

async function authenticateSocket (socket): Promise<?UserHandler> {
  debug('Authenticating user')
  const {userId, token, jwt} = socket.handshake.query || {} // Authenticate token from query
  if (userId && token) {
    debug('Got userId and token', userId, token)
Severity: Minor
Found in src/websocket/socket_io.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function authenticateSocket has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function authenticateSocket (socket): Promise<?UserHandler> {
  debug('Authenticating user')
  const {userId, token, jwt} = socket.handshake.query || {} // Authenticate token from query
  if (userId && token) {
    debug('Got userId and token', userId, token)
Severity: Minor
Found in src/websocket/socket_io.js - About 1 hr to fix

Avoid too many return statements within this function.
Open

  return {day, year, month}
Severity: Major
Found in src/websocket/socket_io.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

  if (day === null) return null
Severity: Major
Found in src/websocket/socket_io.js - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  defineLaundrySocketFunction(socket, 'listUsersAndInvites',
    async laundry => {
      const users = laundry.fetchUsers()
      const invites = laundry.fetchInvites()
      return [actionListUsers(await users), actionsListInvites(await invites)]
Severity: Major
Found in src/websocket/socket_io.js and 1 other location - About 1 hr to fix
src/websocket/socket_io.js on lines 218..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  defineLaundrySocketFunction(socket, 'listMachinesAndUsers',
    async laundry => {
      const users = laundry.fetchUsers()
      const machines = laundry.fetchMachines()
      return [actionListUsers(await users), actionListMachines(await machines)]
Severity: Major
Found in src/websocket/socket_io.js and 1 other location - About 1 hr to fix
src/websocket/socket_io.js on lines 211..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function actionListUsers (users: UserHandler[]): ListUsersAction {
  return {type: 'LIST_USERS', payload: users.map(l => l.reduxModel())}
}
Severity: Major
Found in src/websocket/socket_io.js and 4 other locations - About 1 hr to fix
src/websocket/socket_io.js on lines 374..376
src/websocket/socket_io.js on lines 382..384
src/websocket/socket_io.js on lines 386..388
src/websocket/socket_io.js on lines 390..392

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function actionListBookings (machines: BookingHandler[]): ListBookingsAction {
  return {type: 'LIST_BOOKINGS', payload: machines.map(l => l.reduxModel())}
}
Severity: Major
Found in src/websocket/socket_io.js and 4 other locations - About 1 hr to fix
src/websocket/socket_io.js on lines 374..376
src/websocket/socket_io.js on lines 378..380
src/websocket/socket_io.js on lines 382..384
src/websocket/socket_io.js on lines 390..392

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function actionsListInvites (machines: LaundryInvitationHandler[]): ListInvitationsAction {
  return {type: 'LIST_INVITATIONS', payload: machines.map(l => l.reduxModel())}
}
Severity: Major
Found in src/websocket/socket_io.js and 4 other locations - About 1 hr to fix
src/websocket/socket_io.js on lines 374..376
src/websocket/socket_io.js on lines 378..380
src/websocket/socket_io.js on lines 382..384
src/websocket/socket_io.js on lines 386..388

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function actionListLaundries (laundries: LaundryHandler[]): ListLaundriesAction {
  return {type: 'LIST_LAUNDRIES', payload: laundries.map(l => l.reduxModel())}
}
Severity: Major
Found in src/websocket/socket_io.js and 4 other locations - About 1 hr to fix
src/websocket/socket_io.js on lines 378..380
src/websocket/socket_io.js on lines 382..384
src/websocket/socket_io.js on lines 386..388
src/websocket/socket_io.js on lines 390..392

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

function actionListMachines (machines: MachineHandler[]): ListMachinesAction {
  return {type: 'LIST_MACHINES', payload: machines.map(l => l.reduxModel())}
}
Severity: Major
Found in src/websocket/socket_io.js and 4 other locations - About 1 hr to fix
src/websocket/socket_io.js on lines 374..376
src/websocket/socket_io.js on lines 378..380
src/websocket/socket_io.js on lines 386..388
src/websocket/socket_io.js on lines 390..392

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status