Sign upLogin

lawrencepit/email_reply_parser

View on GitHub
Star

Showing 4 of 4 total issues

Method multiline_quote_header_in_fragment? has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def multiline_quote_header_in_fragment?
      folding = false
      label_groups = []
      @fragment.current_block.split("\n").each do |line|
        if line =~ /\A\s*\*?([^:]+):(\s|\*)/
Severity: Minor
Found in lib/email_reply_parser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method scan_line has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def scan_line(line, last = false)
      line.chomp!("\n")
      line.reverse!
      line.rstrip!
Severity: Minor
Found in lib/email_reply_parser.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method finish_fragment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def finish_fragment
      if @fragment
        @fragment.finish
        if !@found_visible
          if @fragment.quoted? || @fragment.signature? ||
Severity: Minor
Found in lib/email_reply_parser.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return false
Severity: Major
Found in lib/email_reply_parser.rb - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language