lib/middleware/socketio.js

Summary

Maintainability
D
1 day
Test Coverage

Function initialize has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  * initialize(next) {
    logger("using leafjs socketio middleware");

    let leaf = this;
    let koa = leaf.koa;
Severity: Major
Found in lib/middleware/socketio.js - About 4 hrs to fix

    Function initialize has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      * initialize(next) {
        logger("using leafjs socketio middleware");
    
        let leaf = this;
        let koa = leaf.koa;
    Severity: Minor
    Found in lib/middleware/socketio.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handler has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function handler(origHeaders) {
          logger("delete accept-encoding in origHeaders");
          delete origHeaders["accept-encoding"];
          return function _handler(method, route, data, headers, cb) {
            logger(`trigger socket.io s handler, with (${method}, ${route}, ${data}, ${headers})`);
    Severity: Major
    Found in lib/middleware/socketio.js - About 2 hrs to fix

      Function _handler has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            return function _handler(method, route, data, headers, cb) {
              logger(`trigger socket.io s handler, with (${method}, ${route}, ${data}, ${headers})`);
              if (undefined === cb) { //arguments is method, route, headers, cb
                cb = headers;
                headers = data;
      Severity: Major
      Found in lib/middleware/socketio.js - About 2 hrs to fix

        Unnecessary semicolon.
        Open

                      };
        Severity: Minor
        Found in lib/middleware/socketio.js by eslint

        disallow unnecessary semicolons (no-extra-semi)

        Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

        Rule Details

        This rule disallows unnecessary semicolons.

        Examples of incorrect code for this rule:

        /*eslint no-extra-semi: "error"*/
        
        var x = 5;;
        
        function foo() {
            // code
        };

        Examples of correct code for this rule:

        /*eslint no-extra-semi: "error"*/
        
        var x = 5;
        
        var foo = function() {
            // code
        };

        When Not To Use It

        If you intentionally use extra semicolons then you can disable this rule.

        Related Rules

        Expected return with your callback function.
        Open

                      cb(res.status, res.header, res.body);
        Severity: Minor
        Found in lib/middleware/socketio.js by eslint

        Enforce Return After Callback (callback-return)

        The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

        function doSomething(err, callback) {
            if (err) {
                return callback(err);
            }
            callback();
        }

        To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

        Rule Details

        This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

        Options

        The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

        Default callback names

        Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                callback(err);
            }
            callback();
        }

        Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                return callback(err);
            }
            callback();
        }

        Supplied callback names

        Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

        /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
        
        function foo(err, done) {
            if (err) {
                done(err);
            }
            done();
        }
        
        function bar(err, send) {
            if (err) {
                send.error(err);
            }
            send.success();
        }

        Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

        /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
        
        function foo(err, done) {
            if (err) {
                return done(err);
            }
            done();
        }
        
        function bar(err, send) {
            if (err) {
                return send.error(err);
            }
            send.success();
        }

        Known Limitations

        Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

        • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
        • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

        Passing the callback by reference

        The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

        Example of a false negative when this rule reports correct code:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                setTimeout(callback, 0); // this is bad, but WILL NOT warn
            }
            callback();
        }

        Triggering the callback within a nested function

        The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

        Example of a false negative when this rule reports correct code:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                process.nextTick(function() {
                    return callback(); // this is bad, but WILL NOT warn
                });
            }
            callback();
        }

        If/else statements

        The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

        Example of a false positive when this rule reports incorrect code:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                callback(err); // this is fine, but WILL warn
            } else {
                callback();    // this is fine, but WILL warn
            }
        }

        When Not To Use It

        There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

        Further Reading

        Related Rules

        Move function declaration to function body root.
        Open

                      function onEnd(chunk) {
        Severity: Minor
        Found in lib/middleware/socketio.js by eslint

        disallow variable or function declarations in nested blocks (no-inner-declarations)

        In JavaScript, prior to ES6, a function declaration is only allowed in the first level of a program or the body of another function, though parsers sometimes erroneously accept them elsewhere. This only applies to function declarations; named or anonymous function expressions can occur anywhere an expression is permitted.

        // Good
        function doSomething() { }
        
        // Bad
        if (test) {
            function doSomethingElse () { }
        }
        
        function anotherThing() {
            var fn;
        
            if (test) {
        
                // Good
                fn = function expression() { };
        
                // Bad
                function declaration() { }
            }
        }

        A variable declaration is permitted anywhere a statement can go, even nested deeply inside other blocks. This is often undesirable due to variable hoisting, and moving declarations to the root of the program or function body can increase clarity. Note that block bindings (let, const) are not hoisted and therefore they are not affected by this rule.

        /*eslint-env es6*/
        
        // Good
        var foo = 42;
        
        // Good
        if (foo) {
            let bar1;
        }
        
        // Bad
        while (test) {
            var bar2;
        }
        
        function doSomething() {
            // Good
            var baz = true;
        
            // Bad
            if (baz) {
                var quux;
            }
        }

        Rule Details

        This rule requires that function declarations and, optionally, variable declarations be in the root of a program or the body of a function.

        Options

        This rule has a string option:

        • "functions" (default) disallows function declarations in nested blocks
        • "both" disallows function and var declarations in nested blocks

        functions

        Examples of incorrect code for this rule with the default "functions" option:

        /*eslint no-inner-declarations: "error"*/
        
        if (test) {
            function doSomething() { }
        }
        
        function doSomethingElse() {
            if (test) {
                function doAnotherThing() { }
            }
        }

        Examples of correct code for this rule with the default "functions" option:

        /*eslint no-inner-declarations: "error"*/
        
        function doSomething() { }
        
        function doSomethingElse() {
            function doAnotherThing() { }
        }
        
        if (test) {
            asyncCall(id, function (err, data) { });
        }
        
        var fn;
        if (test) {
            fn = function fnExpression() { };
        }

        both

        Examples of incorrect code for this rule with the "both" option:

        /*eslint no-inner-declarations: ["error", "both"]*/
        
        if (test) {
            var foo = 42;
        }
        
        function doAnotherThing() {
            if (test) {
                var bar = 81;
            }
        }

        Examples of correct code for this rule with the "both" option:

        /*eslint no-inner-declarations: "error"*/
        /*eslint-env es6*/
        
        var bar = 42;
        
        if (test) {
            let baz = 43;
        }
        
        function doAnotherThing() {
            var baz = 81;
        }

        When Not To Use It

        The function declaration portion rule will be rendered obsolete when block-scoped functions land in ES6, but until then, it should be left on to enforce valid constructions. Disable checking variable declarations when using [block-scoped-var](block-scoped-var.md) or if declaring variables in nested blocks is acceptable despite hoisting. Source: http://eslint.org/docs/rules/

        Unexpected require().
        Open

                  route += "?" + require("querystring").stringify(data);
        Severity: Minor
        Found in lib/middleware/socketio.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                leaf._sio.on("connection", function(socket) {
                  logger("trigger custom namespace socket.io connection event");
                  logger("emit leaf sio connection event");
                  leaf.sio.emit("connection", socket);
                });
        Severity: Minor
        Found in lib/middleware/socketio.js and 1 other location - About 50 mins to fix
        lib/middleware/socketio.js on lines 113..117

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  leaf._sio.on("connection", function(socket) {
                    logger("trigger custom namespace socket.io connection event");
                    logger("emit leafjs sio connection event");
                    leaf.sio.emit("connection", socket);
                  });
        Severity: Minor
        Found in lib/middleware/socketio.js and 1 other location - About 50 mins to fix
        lib/middleware/socketio.js on lines 126..130

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status