Sign upLogin

leafjs/orient

View on GitHub
Star
src/model.js

Summary

Maintainability
D
2 days
Test Coverage

Function _ensureClass has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _ensureClass(callback) {
        var model = this;
        var db = this.db;
        var schema = this.schema;
        var className = schema._options.className || this.name;
Severity: Major
Found in src/model.js - About 4 hrs to fix

    File model.js has 306 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { EventEmitter } from 'events';
import Schema from './schemas/index';
import Document from './document';
import { waterfall, each, serial } from 'async';
import convertType from './types/convert';
    Severity: Minor
    Found in src/model.js - About 3 hrs to fix

      Function _ensureIndex has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _ensureIndex(OClass, callback) {
        var db = this.db;
        var className = this.name;
        var schema = this.schema;
        var model = this;
      Severity: Major
      Found in src/model.js - About 2 hrs to fix

        Model has 21 functions (exceeds 20 allowed). Consider refactoring.
        Open

        export default class Model extends EventEmitter {
    constructor (name, schema, connection, options, callback) {
        super()
        if(!name) {
            throw new Error('Model name is not defined');
        Severity: Minor
        Found in src/model.js - About 2 hrs to fix

          Function constructor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              constructor (name, schema, connection, options, callback) {
        super()
        if(!name) {
            throw new Error('Model name is not defined');
        }
          Severity: Minor
          Found in src/model.js - About 1 hr to fix

            Function constructor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                constructor (name, schema, connection, options, callback) {
        super()
        if(!name) {
            throw new Error('Model name is not defined');
        }
            Severity: Minor
            Found in src/model.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        if(type === 'EMBEDDED' && schemaType.isObject) {
                                var modelName = className + 'A' + _.capitalize(propName);

                                return new Model(modelName, schemaProp.type, model.connection, {
                                    abstract: true
            Severity: Minor
            Found in src/model.js and 1 other location - About 50 mins to fix
            src/model.js on lines 264..270

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if(item.schemaType.isObject) {
                                    var modelName = className + 'A' + _.capitalize(propName);

                                    return new Model(modelName, item.type, model.connection, {
                                        abstract: true
            Severity: Minor
            Found in src/model.js and 1 other location - About 50 mins to fix
            src/model.js on lines 256..271

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
            Open

            import { EventEmitter } from 'events';
            Severity: Minor
            Found in src/model.js by eslint

            For more information visit Source: http://eslint.org/docs/rules/

            There are no issues that match your filters.

            Category
            Status