learningworks/moodle-block_lw_courses

View on GitHub

Showing 31 of 169 total issues

Function course_image_defaults has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function course_image_defaults() {

        $config = get_config('block_lw_courses');

        if (method_exists($this->output, 'image_url')) {
Severity: Minor
Found in renderer.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return print_error('error');
Severity: Major
Found in renderer.php - About 30 mins to fix

    The function block_lw_courses_get_sorted_courses() has an NPath complexity of 882. The configured NPath complexity threshold is 200.
    Open

    function block_lw_courses_get_sorted_courses($showallcourses = false) {
        global $USER;
    
        $limit = block_lw_courses_get_max_user_courses($showallcourses);
    
    
    Severity: Minor
    Found in locallib.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method lw_courses() has an NPath complexity of 14930208. The configured NPath complexity threshold is 200.
    Open

        public function lw_courses($courses) {
            global $CFG, $PAGE, $DB, $OUTPUT;
            $html = '';
            // LearningWorks.
            $PAGE->requires->js(new moodle_url($CFG->wwwroot.'/blocks/lw_courses/js/custom.js'));
    Severity: Minor
    Found in renderer.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method lw_courses() has a Cyclomatic Complexity of 33. The configured cyclomatic complexity threshold is 10.
    Open

        public function lw_courses($courses) {
            global $CFG, $PAGE, $DB, $OUTPUT;
            $html = '';
            // LearningWorks.
            $PAGE->requires->js(new moodle_url($CFG->wwwroot.'/blocks/lw_courses/js/custom.js'));
    Severity: Minor
    Found in renderer.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The function block_lw_courses_get_sorted_courses() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
    Open

    function block_lw_courses_get_sorted_courses($showallcourses = false) {
        global $USER;
    
        $limit = block_lw_courses_get_max_user_courses($showallcourses);
    
    
    Severity: Minor
    Found in locallib.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Don't use IDs in selectors.
    Open

    [data-block='lw_courses'] #box-or-lines.grid {
    Severity: Minor
    Found in styles.css by csslint

    Don't use IDs in selectors.
    Open

    [dir="ltl"] [data-block='lw_courses'] #box-or-lines {
    Severity: Minor
    Found in styles.css by csslint

    Don't use IDs in selectors.
    Open

    .block_lw_courses #box-or-lines.grid,
    Severity: Minor
    Found in styles.css by csslint

    Don't use IDs in selectors.
    Open

    [dir="ltr"] .block_lw_courses #box-or-lines,
    Severity: Minor
    Found in styles.css by csslint

    Don't use IDs in selectors.
    Open

    .editing #box-or-lines {
    Severity: Minor
    Found in styles.css by csslint
    Severity
    Category
    Status
    Source
    Language