leboncoin/concourse-fiaas-resource

View on GitHub

Showing 2 of 7 total issues

Function run has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def run(self, command):
        """Parse input/arguments, perform requested command return output."""
        try:
            input = json.loads(self.fdin.read())
        except ValueError as e:
Severity: Minor
Found in assets/resource.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _logging has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _logging(self, config=None):
        logconf = False
        logpath = os.environ.get(self.LOGENVCONF, config)
        if logpath:
            logpath = os.path.expandvars(logpath)
Severity: Minor
Found in assets/resource.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language