Sign upLogin

lebretr/sequelize-oracle

View on GitHub
Star
lib/dialects/abstract/query.js

Summary

Maintainability
F
3 days
Test Coverage

Function exports has 235 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (function() {
  var AbstractQuery = function(database, sequelize, callee, options) {}

  /**
    Inherit from CustomEventEmitter
Severity: Major
Found in lib/dialects/abstract/query.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = (function() {
  var AbstractQuery = function(database, sequelize, callee, options) {}

  /**
    Inherit from CustomEventEmitter
    Severity: Minor
    Found in lib/dialects/abstract/query.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function groupJoinData has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var groupJoinData = function(data, includeOptions, options) {
    var results = []
      , existingResult
      , calleeData
      , child
    Severity: Major
    Found in lib/dialects/abstract/query.js - About 2 hrs to fix

      Function handleSelectQuery has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var handleSelectQuery = function(results) {
    var result = null

    // Raw queries
    if (this.options.raw) {
      Severity: Major
      Found in lib/dialects/abstract/query.js - About 2 hrs to fix

        Function formatResults has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          AbstractQuery.prototype.formatResults = function(data) {
    var result  = this.callee

    if (isInsertQuery.call(this, data)) {
      handleInsertQuery.call(this, data)
        Severity: Minor
        Found in lib/dialects/abstract/query.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (this.options.logging === console.log) {
      // using just console.log will break in node < 0.6
      this.options.logging = function(s) { console.log(s) }
    }
          Severity: Major
          Found in lib/dialects/abstract/query.js and 1 other location - About 1 hr to fix
          lib/migrator.js on lines 24..27

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              if (this.options.logging === true) {
      console.log('DEPRECATION WARNING: The logging-option should be either a function or false. Default: console.log')
      this.options.logging = console.log
    }
          Severity: Major
          Found in lib/dialects/abstract/query.js and 2 other locations - About 40 mins to fix
          lib/migrator.js on lines 19..22
          lib/sequelize.js on lines 99..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status