Showing 3 of 7 total issues
Method mark_collection_as_read has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def mark_collection_as_read(collection, reader)
ReadMark.transaction do
global_timestamp = reader.read_mark_global(self).try(:timestamp)
collection.each do |obj|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method unread? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def unread?(reader)
if self.respond_to?(:read_mark_id) && read_mark_id_belongs_to?(reader)
# For use with scope "with_read_marks_for"
return false if self.read_mark_id
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method mark_collection_item_as_read has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def mark_collection_item_as_read(obj, reader, timestamp)
marking_proc = proc {
rm = obj.read_marks.find_or_initialize_by(reader: reader)
rm.timestamp = timestamp
rm.save!- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"