File Chart.Overlay.js
has 463 lines of code (exceeds 250 allowed). Consider refactoring. Open
(function() {
"use strict";
var root = this,
Chart = root.Chart,
Function initialize
has 140 lines of code (exceeds 25 allowed). Consider refactoring. Open
initialize: function(data) {
//Expose options as a scope variable here so we can access it in the ScaleClass
var options = this.options;
//two new varibale to hold the different graph types
this.barDatasets = [];
Function showTooltip
has 131 lines of code (exceeds 25 allowed). Consider refactoring. Open
showTooltip: function(ChartElements, forceRedraw) {
// Only redraw the chart if we've actually changed what we're hovering on.
if (typeof this.activeElements === 'undefined') this.activeElements = [];
var isChanged = (function(Elements) {
var changed = false;
Function buildScale
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
buildScale: function(labels) {
var self = this;
var dataTotal = function() {
var values = [];
Function medianPosition
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
medianPosition = (function(index) {
// Get all the points at that particular index
var Elements = [],
dataCollection,
Function addData
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
addData: function(valuesArray, label) {
//Map the values array for each of the datasets
var lineDataSetIndex = 0;
var barDataSetIndex = 0;
Avoid deeply nested control flow statements. Open
if (dataIndex !== -1) {
break;
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
(function() {
"use strict";
var root = this,
Chart = root.Chart,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 5582.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76