Sign upLogin

leksyib/iReporter

View on GitHub
Star
server/controllers/userController.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function signIn has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static async signIn(req, res) {
    const errors = validationResult(req).array().map(error => error.msg);
    if (errors.length < 1) {
      const { username, password } = req.body;
      const user = await User.findOneByUsername(username);
Severity: Minor
Found in server/controllers/userController.js - About 1 hr to fix

    Function signUp has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static async signUp(req, res) {
    const errors = validationResult(req).array().map(error => error.msg);
    if (errors.length < 1) {
      const userObj = req.body;
      userObj.password = bcrypt.hashSync(userObj.password, 10);
    Severity: Minor
    Found in server/controllers/userController.js - About 1 hr to fix

      Function signIn has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        static async signIn(req, res) {
    const errors = validationResult(req).array().map(error => error.msg);
    if (errors.length < 1) {
      const { username, password } = req.body;
      const user = await User.findOneByUsername(username);
      Severity: Minor
      Found in server/controllers/userController.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function signUp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        static async signUp(req, res) {
    const errors = validationResult(req).array().map(error => error.msg);
    if (errors.length < 1) {
      const userObj = req.body;
      userObj.password = bcrypt.hashSync(userObj.password, 10);
      Severity: Minor
      Found in server/controllers/userController.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status