Sign upLogin

leonhooijer/zadok

View on GitHub
Star

Showing 2 of 4 total issues

Class ZadokController has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

class ZadokController < ApplicationController
  helper_method :edit_attributes
  helper_method :index_attributes
  helper_method :new_attributes
  helper_method :page_title
Severity: Minor
Found in app/controllers/zadok_controller.rb - About 3 hrs to fix

    Method key_from_range_ends has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def key_from_range_ends(left, right)
          if left && right
            "closed" if left != right
          elsif right
            "left_open"
    Severity: Minor
    Found in lib/zadok/filters/ransack/numeric_range_filter.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language