Sign upLogin

lgaticaq/meitrack-parser

View on GitHub
Star

Showing 4 of 6 total issues

Function getMvt380 has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getMvt380 = raw => {
  const match = patterns.mvt380.exec(raw)
  const status = match[27]
    .split('')
    .map(x => pad(4, parseInt(x, 10).toString(2), '0'))
Severity: Major
Found in src/index.js - About 2 hrs to fix

    Function parseAlrm has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const parseAlrm = event => {
  const alarms = {
    '1': { type: 'SOS_Button' },
    '2': { type: 'DI', number: 2, status: true },
    '3': { type: 'DI', number: 3, status: true },
    Severity: Major
    Found in src/index.js - About 2 hrs to fix

      Function parseCommand has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      const parseCommand = data => {
  let raw, state, port, speed, interval
  if (/^[1-5]{1}_(on|off|status)$/.test(data.instruction)) {
    let _data = data.instruction.split('_')
    port = _data[0]
      Severity: Minor
      Found in src/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseCommand has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const parseCommand = data => {
  let raw, state, port, speed, interval
  if (/^[1-5]{1}_(on|off|status)$/.test(data.instruction)) {
    let _data = data.instruction.split('_')
    port = _data[0]
      Severity: Minor
      Found in src/index.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language