lgaticaq/node-nmea

View on GitHub

Showing 3 of 7 total issues

Function parseRmc has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const parseRmc = raw => {
  let data = { raw: raw, valid: false }
  const r = gprmc.exec(raw)
  if (isValid(raw)) {
    data.type = r[1]
Severity: Minor
Found in src/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseRmc has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const parseRmc = raw => {
  let data = { raw: raw, valid: false }
  const r = gprmc.exec(raw)
  if (isValid(raw)) {
    data.type = r[1]
Severity: Minor
Found in src/index.js - About 1 hr to fix

    Function parseGga has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const parseGga = raw => {
      let data = { raw: raw, valid: false }
      const r = gpgga.exec(raw)
      data.raw = raw
      data.type = r[1]
    Severity: Minor
    Found in src/index.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language