Sign upLogin

lgierth/promise.rb

View on GitHub
Star

Showing 3 of 5 total issues

Class Promise has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class Promise
  Error = Class.new(RuntimeError)
  BrokenError = Class.new(Error)

  include Promise::Progress
Severity: Minor
Found in lib/promise.rb - About 2 hrs to fix

    Method fulfill has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def fulfill(value = nil)
    return self unless pending?

    if value.is_a?(Promise)
      case value.state
    Severity: Minor
    Found in lib/promise.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reason_coercion has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def reason_coercion(reason)
    case reason
    when Exception
      reason.set_backtrace(caller) unless reason.backtrace
    when Class
    Severity: Minor
    Found in lib/promise.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language